breaking: remove deprecated commands and code (#9521)

* breaking: remove deprecated commands

* feat: remove deprecated code and usages

* refactor: remove more logic around default relations

* fix tests

* remove log

* fix: remove defaultFields usage

* fix: add back accidentally removed code

* refactor: implement feedback

* feat: add --cluster flag to the start command

* refactor: assign limit to defaultLimit property

* fix: breaking code because of removed check

---------

Co-authored-by: adrien2p <adrien.deperetti@gmail.com>

packages/modules/fulfillment/src/utils/events.ts

@@ -20,151 +20,151 @@ export const eventBuilders = {
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "fulfillment",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.FULFILLMENT_CREATED,
   }),
   updatedFulfillment: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.UPDATED,
     object: "fulfillment",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.FULFILLMENT_UPDATED,
   }),
   createdFulfillmentAddress: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "fulfillment_address",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.FULFILLMENT_ADDRESS_CREATED,
   }),
   createdFulfillmentItem: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "fulfillment_item",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.FULFILLMENT_ITEM_CREATED,
   }),
   createdFulfillmentLabel: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "fulfillment_label",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.FULFILLMENT_LABEL_CREATED,
   }),
   updatedFulfillmentLabel: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.UPDATED,
     object: "fulfillment_label",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.FULFILLMENT_LABEL_UPDATED,
   }),
   deletedFulfillmentLabel: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.DELETED,
     object: "fulfillment_label",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.FULFILLMENT_LABEL_DELETED,
   }),
   createdShippingProfile: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "shipping_profile",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SHIPPING_PROFILE_CREATED,
   }),
   createdShippingOptionType: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "shipping_option_type",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SHIPPING_OPTION_TYPE_CREATED,
   }),
   updatedShippingOptionType: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.UPDATED,
     object: "shipping_option_type",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SHIPPING_OPTION_TYPE_UPDATED,
   }),
   deletedShippingOptionType: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.DELETED,
     object: "shipping_option_type",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SHIPPING_OPTION_TYPE_DELETED,
   }),
   createdShippingOptionRule: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "shipping_option_rule",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SHIPPING_OPTION_RULE_CREATED,
   }),
   updatedShippingOptionRule: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.UPDATED,
     object: "shipping_option_rule",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SHIPPING_OPTION_RULE_UPDATED,
   }),
   deletedShippingOptionRule: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.DELETED,
     object: "shipping_option_rule",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SHIPPING_OPTION_RULE_DELETED,
   }),
   createdShippingOption: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "shipping_option",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SHIPPING_OPTION_CREATED,
   }),
   updatedShippingOption: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.UPDATED,
     object: "shipping_option",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SHIPPING_OPTION_UPDATED,
   }),
   createdFulfillmentSet: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "fulfillment_set",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.FULFILLMENT_SET_CREATED,
   }),
   updatedFulfillmentSet: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.UPDATED,
     object: "fulfillment_set",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.FULFILLMENT_SET_UPDATED,
   }),
   deletedFulfillmentSet: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.DELETED,
     object: "fulfillment_set",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.FULFILLMENT_SET_DELETED,
   }),
   createdServiceZone: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "service_zone",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SERVICE_ZONE_CREATED,
   }),
   updatedServiceZone: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.UPDATED,
     object: "service_zone",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SERVICE_ZONE_UPDATED,
   }),
   deletedServiceZone: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.DELETED,
     object: "service_zone",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.SERVICE_ZONE_DELETED,
   }),
   createdGeoZone: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.CREATED,
     object: "geo_zone",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.GEO_ZONE_CREATED,
   }),
   updatedGeoZone: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.UPDATED,
     object: "geo_zone",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.GEO_ZONE_UPDATED,
   }),
   deletedGeoZone: moduleEventBuilderFactory({
     source: Modules.FULFILLMENT,
     action: CommonEvents.DELETED,
     object: "geo_zone",
-    eventsEnum: FulfillmentEvents,
+    eventName: FulfillmentEvents.GEO_ZONE_DELETED,
   }),
 }
 

packages/modules/notification/src/utils/events.ts

@@ -10,6 +10,6 @@ export const eventBuilders = {
     source: Modules.NOTIFICATION,
     action: CommonEvents.CREATED,
     object: "notification",
-    eventsEnum: NotificationEvents,
+    eventName: NotificationEvents.NOTIFICATION_CREATED,
   }),
 }

packages/modules/pricing/src/utils/events.ts

@@ -10,60 +10,60 @@ export const eventBuilders = {
     source: Modules.PRICING,
     action: CommonEvents.CREATED,
     object: "price_set",
-    eventsEnum: PricingEvents,
+    eventName: PricingEvents.PRICE_SET_CREATED,
   }),
   createdPrice: moduleEventBuilderFactory({
     source: Modules.PRICING,
     action: CommonEvents.CREATED,
     object: "price",
-    eventsEnum: PricingEvents,
+    eventName: PricingEvents.PRICE_CREATED,
   }),
   createdPriceRule: moduleEventBuilderFactory({
     source: Modules.PRICING,
     action: CommonEvents.CREATED,
     object: "price_rule",
-    eventsEnum: PricingEvents,
+    eventName: PricingEvents.PRICE_RULE_CREATED,
   }),
   createdPriceList: moduleEventBuilderFactory({
     source: Modules.PRICING,
     action: CommonEvents.CREATED,
     object: "price_list",
-    eventsEnum: PricingEvents,
+    eventName: PricingEvents.PRICE_LIST_CREATED,
   }),
   createdPriceListRule: moduleEventBuilderFactory({
     source: Modules.PRICING,
     action: CommonEvents.CREATED,
     object: "price_list_rule",
-    eventsEnum: PricingEvents,
+    eventName: PricingEvents.PRICE_LIST_RULE_CREATED,
   }),
   attachedPriceListRule: moduleEventBuilderFactory({
     source: Modules.PRICING,
     action: CommonEvents.ATTACHED,
     object: "price_list_rule",
-    eventsEnum: PricingEvents,
+    eventName: PricingEvents.PRICE_LIST_RULE_ATTACHED,
   }),
   updatedPrice: moduleEventBuilderFactory({
     source: Modules.PRICING,
     action: CommonEvents.UPDATED,
     object: "price",
-    eventsEnum: PricingEvents,
+    eventName: PricingEvents.PRICE_UPDATED,
   }),
   updatedPriceRule: moduleEventBuilderFactory({
     source: Modules.PRICING,
     action: CommonEvents.UPDATED,
     object: "price_rule",
-    eventsEnum: PricingEvents,
+    eventName: PricingEvents.PRICE_RULE_UPDATED,
   }),
   deletedPrice: moduleEventBuilderFactory({
     source: Modules.PRICING,
     action: CommonEvents.DELETED,
     object: "price",
-    eventsEnum: PricingEvents,
+    eventName: PricingEvents.PRICE_DELETED,
   }),
   deletedPriceRule: moduleEventBuilderFactory({
     source: Modules.PRICING,
     action: CommonEvents.DELETED,
     object: "price_rule",
-    eventsEnum: PricingEvents,
+    eventName: PricingEvents.PRICE_RULE_DELETED,
   }),
 }

packages/modules/product/integration-tests/__tests__/product-module-service/product-categories.spec.ts

@@ -680,7 +680,6 @@ moduleIntegrationTestRunner<IProductModuleService>({
           productCategoryTwo = categories[2]
         })
 
-        // TODO: Normalize delete events as well
         it("should emit events through event bus", async () => {
           const eventBusSpy = jest.spyOn(MockEventBusService.prototype, "emit")
           eventBusSpy.mockClear()

packages/modules/product/src/utils/events.ts

@@ -10,109 +10,109 @@ export const eventBuilders = {
     source: Modules.PRODUCT,
     action: CommonEvents.CREATED,
     object: "product",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_CREATED,
   }),
   updatedProduct: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.UPDATED,
     object: "product",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_UPDATED,
   }),
   deletedProduct: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.DELETED,
     object: "product",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_DELETED,
   }),
   createdProductVariant: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.CREATED,
     object: "product_variant",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_VARIANT_CREATED,
   }),
   updatedProductVariant: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.UPDATED,
     object: "product_variant",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_VARIANT_UPDATED,
   }),
   deletedProductVariant: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.DELETED,
     object: "product_variant",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_VARIANT_DELETED,
   }),
   createdProductOption: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.CREATED,
     object: "product_option",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_OPTION_CREATED,
   }),
   updatedProductOption: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.UPDATED,
     object: "product_option",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_OPTION_UPDATED,
   }),
   deletedProductOption: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.DELETED,
     object: "product_option",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_OPTION_DELETED,
   }),
   createdProductType: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.CREATED,
     object: "product_type",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_TYPE_CREATED,
   }),
   updatedProductType: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.UPDATED,
     object: "product_type",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_TYPE_UPDATED,
   }),
   deletedProductType: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.DELETED,
     object: "product_type",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_TYPE_DELETED,
   }),
   createdProductTag: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.CREATED,
     object: "product_tag",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_TAG_CREATED,
   }),
   updatedProductTag: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.UPDATED,
     object: "product_tag",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_TAG_UPDATED,
   }),
   deletedProductTag: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.DELETED,
     object: "product_tag",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_TAG_DELETED,
   }),
   createdProductCategory: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.CREATED,
     object: "product_category",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_CATEGORY_CREATED,
   }),
   updatedProductCategory: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.UPDATED,
     object: "product_category",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_CATEGORY_UPDATED,
   }),
   deletedProductCategory: moduleEventBuilderFactory({
     source: Modules.PRODUCT,
     action: CommonEvents.DELETED,
     object: "product_category",
-    eventsEnum: ProductEvents,
+    eventName: ProductEvents.PRODUCT_CATEGORY_DELETED,
   }),
   createdProductCollection: moduleEventBuilderFactory({
     source: Modules.PRODUCT,