From adbeb9cc1d7e9045e1e9c556ab42d2b9970ee7b8 Mon Sep 17 00:00:00 2001 From: "Carlos R. L. Rodrigues" <37986729+carlos-r-l-rodrigues@users.noreply.github.com> Date: Wed, 18 Sep 2024 08:44:11 -0300 Subject: [PATCH] fix(workflow-engine-*): pass container to flow (#9180) --- .../src/services/workflow-orchestrator.ts | 21 ++++++------------- .../src/services/workflow-orchestrator.ts | 9 ++++---- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/packages/modules/workflow-engine-inmemory/src/services/workflow-orchestrator.ts b/packages/modules/workflow-engine-inmemory/src/services/workflow-orchestrator.ts index ccb849b242..45a726c0b5 100644 --- a/packages/modules/workflow-engine-inmemory/src/services/workflow-orchestrator.ts +++ b/packages/modules/workflow-engine-inmemory/src/services/workflow-orchestrator.ts @@ -166,17 +166,14 @@ export class WorkflowOrchestratorService { ) } - const flow = exportedWorkflow( - (container as MedusaContainer) ?? this.container_ - ) - - const ret = await flow.run({ + const ret = await exportedWorkflow.run({ input, throwOnError, logOnError, resultFrom, context, events, + container: container ?? this.container_, }) const hasFinished = ret.transaction.hasFinished() @@ -276,17 +273,13 @@ export class WorkflowOrchestratorService { throw new Error(`Workflow with id "${workflowId}" not found.`) } - const flow = exportedWorkflow( - (container as MedusaContainer) ?? this.container_ - ) - const events = this.buildWorkflowEvents({ customEventHandlers: eventHandlers, transactionId, workflowId, }) - const ret = await flow.registerStepSuccess({ + const ret = await exportedWorkflow.registerStepSuccess({ idempotencyKey: idempotencyKey_, context, resultFrom, @@ -294,6 +287,7 @@ export class WorkflowOrchestratorService { logOnError, events, response: stepResponse, + container: container ?? this.container_, }) if (ret.transaction.hasFinished()) { @@ -343,17 +337,13 @@ export class WorkflowOrchestratorService { throw new Error(`Workflow with id "${workflowId}" not found.`) } - const flow = exportedWorkflow( - (container as MedusaContainer) ?? this.container_ - ) - const events = this.buildWorkflowEvents({ customEventHandlers: eventHandlers, transactionId, workflowId, }) - const ret = await flow.registerStepFailure({ + const ret = await exportedWorkflow.registerStepFailure({ idempotencyKey: idempotencyKey_, context, resultFrom, @@ -361,6 +351,7 @@ export class WorkflowOrchestratorService { logOnError, events, response: stepResponse, + container: container ?? this.container_, }) if (ret.transaction.hasFinished()) { diff --git a/packages/modules/workflow-engine-redis/src/services/workflow-orchestrator.ts b/packages/modules/workflow-engine-redis/src/services/workflow-orchestrator.ts index 30d5c7e713..7f82432c8a 100644 --- a/packages/modules/workflow-engine-redis/src/services/workflow-orchestrator.ts +++ b/packages/modules/workflow-engine-redis/src/services/workflow-orchestrator.ts @@ -220,6 +220,7 @@ export class WorkflowOrchestratorService { resultFrom, context, events, + container: container ?? this.container_, }) const hasFinished = ret.transaction.hasFinished() @@ -332,6 +333,7 @@ export class WorkflowOrchestratorService { logOnError, events, response: stepResponse, + container: container ?? this.container_, }) if (ret.transaction.hasFinished()) { @@ -381,17 +383,13 @@ export class WorkflowOrchestratorService { throw new Error(`Workflow with id "${workflowId}" not found.`) } - const flow = exportedWorkflow( - (container as MedusaContainer) ?? this.container_ - ) - const events = this.buildWorkflowEvents({ customEventHandlers: eventHandlers, transactionId, workflowId, }) - const ret = await flow.registerStepFailure({ + const ret = await exportedWorkflow.registerStepFailure({ idempotencyKey: idempotencyKey_, context, resultFrom, @@ -399,6 +397,7 @@ export class WorkflowOrchestratorService { logOnError, events, response: stepResponse, + container: container ?? this.container_, }) if (ret.transaction.hasFinished()) {