From ae372de305ca12b1d8562e14868bee2d223b9c32 Mon Sep 17 00:00:00 2001 From: Sebastian Rindom Date: Mon, 29 Jun 2020 17:17:16 +0200 Subject: [PATCH] Pass tests --- .../__tests__/create-shipping-options.js | 33 ------------------- .../store/carts/create-shipping-options.js | 17 ---------- .../services/__mocks__/payment-provider.js | 14 +++----- packages/medusa/src/services/cart.js | 1 - 4 files changed, 4 insertions(+), 61 deletions(-) delete mode 100644 packages/medusa/src/api/routes/store/carts/__tests__/create-shipping-options.js delete mode 100644 packages/medusa/src/api/routes/store/carts/create-shipping-options.js diff --git a/packages/medusa/src/api/routes/store/carts/__tests__/create-shipping-options.js b/packages/medusa/src/api/routes/store/carts/__tests__/create-shipping-options.js deleted file mode 100644 index 0173d5e8e2..0000000000 --- a/packages/medusa/src/api/routes/store/carts/__tests__/create-shipping-options.js +++ /dev/null @@ -1,33 +0,0 @@ -import { IdMap } from "medusa-test-utils" -import { request } from "../../../../../helpers/test-request" -import { CartServiceMock } from "../../../../../services/__mocks__/cart" - -describe("POST /store/carts/:id/shipping-options", () => { - describe("creates shipping options", () => { - let subject - - beforeAll(async () => { - subject = await request( - "POST", - `/store/carts/${IdMap.getId("emptyCart")}/shipping-options` - ) - }) - - afterAll(() => { - jest.clearAllMocks() - }) - - it("calls Cart service set shipping options", () => { - expect(CartServiceMock.setShippingOptions).toHaveBeenCalledTimes(1) - }) - - it("returns 200", () => { - expect(subject.status).toEqual(200) - }) - - it("returns the cart", () => { - expect(subject.body.cart._id).toEqual(IdMap.getId("emptyCart")) - expect(subject.body.cart.decorated).toEqual(true) - }) - }) -}) diff --git a/packages/medusa/src/api/routes/store/carts/create-shipping-options.js b/packages/medusa/src/api/routes/store/carts/create-shipping-options.js deleted file mode 100644 index e23c897f23..0000000000 --- a/packages/medusa/src/api/routes/store/carts/create-shipping-options.js +++ /dev/null @@ -1,17 +0,0 @@ -export default async (req, res) => { - const { id } = req.params - - try { - const cartService = req.scope.resolve("cartService") - - // Ask the cart service to set payment sessions - await cartService.setShippingOptions(id) - - // return the updated cart - let cart = await cartService.retrieve(id) - cart = await cartService.decorate(cart) - res.status(200).json({ cart }) - } catch (err) { - throw err - } -} diff --git a/packages/medusa/src/services/__mocks__/payment-provider.js b/packages/medusa/src/services/__mocks__/payment-provider.js index 3cd2b709cc..8f705a58be 100644 --- a/packages/medusa/src/services/__mocks__/payment-provider.js +++ b/packages/medusa/src/services/__mocks__/payment-provider.js @@ -17,20 +17,14 @@ export const DefaultProviderMock = { export const PaymentProviderServiceMock = { updateSession: jest.fn().mockImplementation((session, cart) => { return Promise.resolve({ - provider_id: session.provider_id, - data: { - ...session.data, - id: `${session.data.id}_updated`, - }, + ...session.data, + id: `${session.data.id}_updated`, }) }), createSession: jest.fn().mockImplementation((providerId, cart) => { return Promise.resolve({ - provider_id: providerId, - data: { - id: `${providerId}_session`, - cartId: cart._id, - }, + id: `${providerId}_session`, + cartId: cart._id, }) }), retrieveProvider: jest.fn().mockImplementation(providerId => { diff --git a/packages/medusa/src/services/cart.js b/packages/medusa/src/services/cart.js index 73c27a60c2..cc3f9f25fb 100644 --- a/packages/medusa/src/services/cart.js +++ b/packages/medusa/src/services/cart.js @@ -448,7 +448,6 @@ class CartService extends BaseService { const cart = await this.retrieve(cartId) const { value, error } = Validator.address().validate(address) if (error) { - console.log(error) throw new MedusaError( MedusaError.Types.INVALID_DATA, "The address is not valid"