asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(medusa): Delete all payment sessions when cart total is 0 (#3346)

Browse Source 
* Fix(medusa): On cart total amount at 0 the non initialised payment sessions are not delete

* fix test

* Create good-crews-pull.md
This commit is contained in:
Adrien de Peretti
2023-03-01 13:22:25 +01:00
committed by GitHub
parent 84b6fe1d93
commit b458615ed5
3 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/medusa/src/services/__tests__/cart.js
+8 -8
View File
@@ -1688,8 +1688,8 @@ describe("CartService", () => {
expect(paymentSessionRepositoryMock.create).toHaveBeenCalledTimes(1)
expect(paymentSessionRepositoryMock.save).toHaveBeenCalledTimes(2) // create and update
expect(paymentSessionRepositoryMock.delete).toHaveBeenCalledTimes(1)
expect(paymentSessionRepositoryMock.delete).toHaveBeenCalledWith({
expect(paymentSessionRepositoryMock.remove).toHaveBeenCalledTimes(1)
expect(paymentSessionRepositoryMock.remove).toHaveBeenCalledWith({
provider_id: "not_in_region",
})
})
@@ -1697,12 +1697,12 @@ describe("CartService", () => {
it("removes if cart total === 0", async () => {
await cartService.setPaymentSessions(IdMap.getId("cart-remove"))
expect(paymentSessionRepositoryMock.delete).toHaveBeenCalledTimes(2)
expect(paymentSessionRepositoryMock.remove).toHaveBeenCalledTimes(2)
expect(paymentSessionRepositoryMock.delete).toHaveBeenCalledWith({
expect(paymentSessionRepositoryMock.remove).toHaveBeenCalledWith({
provider_id: provider1Id,
})
expect(paymentSessionRepositoryMock.delete).toHaveBeenCalledWith({
expect(paymentSessionRepositoryMock.remove).toHaveBeenCalledWith({
provider_id: provider2Id,
})
})
@@ -1710,12 +1710,12 @@ describe("CartService", () => {
it("removes if cart total < 0", async () => {
await cartService.setPaymentSessions(IdMap.getId("cart-negative"))
expect(paymentSessionRepositoryMock.delete).toHaveBeenCalledTimes(2)
expect(paymentSessionRepositoryMock.remove).toHaveBeenCalledTimes(2)
expect(paymentSessionRepositoryMock.delete).toHaveBeenCalledWith({
expect(paymentSessionRepositoryMock.remove).toHaveBeenCalledWith({
provider_id: provider1Id,
})
expect(paymentSessionRepositoryMock.delete).toHaveBeenCalledWith({
expect(paymentSessionRepositoryMock.remove).toHaveBeenCalledWith({
provider_id: provider2Id,
})
})
packages/medusa/src/services/cart.ts
+1 -1
View File
@@ -1821,7 +1821,7 @@ class CartService extends TransactionBaseService {
return paymentProviderServiceTx.deleteSession(session)
}
return psRepo.delete(session)
return psRepo.remove(session)
}
// In the case of a cart that has a total <= 0 we can return prematurely.