chore(medusa): Prefer logger instead of console.log (#5846)

* chore(medusa): Prefer logger instead of console.log

* Create nasty-comics-leave.md

* fix imports
This commit is contained in:
Adrien de Peretti
2023-12-13 16:09:48 +01:00
committed by GitHub
parent 245e5c9a69
commit b5748ab59e
14 changed files with 46 additions and 20 deletions
@@ -18,6 +18,7 @@ import {
import { FindParams } from "../../../../types/common"
import { OrdersReturnItem } from "../../../../types/orders"
import { cleanResponseData } from "../../../../utils/clean-response-data"
import { Logger } from "@medusajs/types"
/**
* @oas [post] /admin/orders/{id}/return
@@ -105,6 +106,7 @@ export default async (req, res) => {
const idempotencyKeyService = req.scope.resolve("idempotencyKeyService")
const manager: EntityManager = req.scope.resolve("manager")
const logger: Logger = req.scope.resolve("logger")
const headerKey = req.get("Idempotency-Key") || ""
@@ -284,7 +286,7 @@ export default async (req, res) => {
res.status(idempotencyKey.response_code).json(idempotencyKey.response_body)
} catch (err) {
console.log(err)
logger.log(err)
throw err
}
}
@@ -3,6 +3,7 @@ import { CartService, IdempotencyKeyService } from "../../../../services"
import { EntityManager } from "typeorm"
import { IdempotencyKey } from "../../../../models/idempotency-key"
import { cleanResponseData } from "../../../../utils/clean-response-data"
import { Logger } from "@medusajs/types"
/**
* @oas [post] /store/carts/{id}/taxes
@@ -49,6 +50,7 @@ export default async (req, res) => {
"idempotencyKeyService"
)
const manager: EntityManager = req.scope.resolve("manager")
const logger: Logger = req.scope.resolve("logger")
const headerKey = req.get("Idempotency-Key") || ""
@@ -61,7 +63,7 @@ export default async (req, res) => {
.initializeRequest(headerKey, req.method, req.params, req.path)
})
} catch (error) {
console.log(error)
logger.log(error)
res.status(409).send("Failed to create idempotency key")
return
}
@@ -3,6 +3,7 @@ import { AbstractCartCompletionStrategy } from "../../../../interfaces"
import { IdempotencyKey } from "../../../../models"
import { IdempotencyKeyService } from "../../../../services"
import { cleanResponseData } from "../../../../utils/clean-response-data"
import { Logger } from "@medusajs/types"
/**
* @oas [post] /store/carts/{id}/complete
@@ -66,6 +67,7 @@ export default async (req, res) => {
const idempotencyKeyService: IdempotencyKeyService = req.scope.resolve(
"idempotencyKeyService"
)
const logger: Logger = req.scope.resolve("logger")
const headerKey = req.get("Idempotency-Key") || ""
@@ -77,7 +79,7 @@ export default async (req, res) => {
.initializeRequest(headerKey, req.method, req.params, req.path)
})
} catch (error) {
console.log(error)
logger.log(error)
res.status(409).send("Failed to create idempotency key")
return
}
@@ -1,6 +1,7 @@
import { defaultStoreGiftCardFields, defaultStoreGiftCardRelations } from "."
import GiftCardService from "../../../../services/gift-card"
import { Logger } from "@medusajs/types"
/**
* @oas [get] /store/gift-cards/{code}
@@ -58,7 +59,8 @@ export default async (req, res) => {
res.json({ gift_card: giftCard })
} catch (error) {
console.log(error)
const logger: Logger = req.scope.resolve("logger")
logger.log(error)
throw error
}
}
@@ -16,6 +16,7 @@ import IdempotencyKeyService from "../../../../services/idempotency-key"
import ReturnService from "../../../../services/return"
import { validator } from "../../../../utils/validator"
import { defaultRelations } from "."
import { Logger } from "@medusajs/types"
/**
* @oas [post] /store/returns
@@ -225,7 +226,8 @@ export default async (req, res) => {
res.status(idempotencyKey.response_code).json(idempotencyKey.response_body)
} catch (err) {
console.log(err)
const logger: Logger = req.scope.resolve("logger")
logger.log(err)
throw err
}
}