asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #564 from saurabh042/chore/lint

Browse Source 
fix: Chore/lint chore: Make packages/medusa/src/services/inventory.js pass linting #509
This commit is contained in:
Sebastian Rindom
2021-10-20 09:55:05 +02:00
committed by GitHub
parent 4f35041885 8d84eb9ba5
commit bfecfa7c78
3 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.eslintignore
-1
View File
@@ -4,7 +4,6 @@
/packages/medusa/src/services/claim-item.js /packages/medusa/src/services/claim-item.js
/packages/medusa/src/services/event-bus.js /packages/medusa/src/services/event-bus.js
/packages/medusa/src/services/fulfillment-provider.js /packages/medusa/src/services/fulfillment-provider.js
/packages/medusa/src/services/inventory.js
/packages/medusa/src/services/middleware.js /packages/medusa/src/services/middleware.js
/packages/medusa/src/services/oauth.js /packages/medusa/src/services/oauth.js
/packages/medusa/src/services/payment-provider.js /packages/medusa/src/services/payment-provider.js
packages/medusa/src/services/fulfillment-provider.js
+3 -2
View File
@@ -28,7 +28,7 @@ class FulfillmentProviderService {
async listFulfillmentOptions(providers) { async listFulfillmentOptions(providers) {
const result = await Promise.all( const result = await Promise.all(
providers.map(async p => { providers.map(async (p) => {
const provider = await this.retrieveProvider(p) const provider = await this.retrieveProvider(p)
return { return {
provider_id: p, provider_id: p,
@@ -41,7 +41,8 @@ class FulfillmentProviderService {
} }
/** /**
* @returns {FulfillmentService} the payment fulfillment provider * @param {string} provider_id - the provider id
* @return {FulfillmentService} the payment fulfillment provider
*/ */
retrieveProvider(provider_id) { retrieveProvider(provider_id) {
try { try {
packages/medusa/src/services/inventory.js
+9 -9
View File
@@ -29,19 +29,19 @@ class InventoryService extends BaseService {
/** /**
* Updates the inventory of a variant based on a given adjustment. * Updates the inventory of a variant based on a given adjustment.
* @params {string} variantId - the id of the variant to update * @param {string} variantId - the id of the variant to update
* @params {number} adjustment - the number to adjust the inventory quantity by * @param {number} adjustment - the number to adjust the inventory quantity by
* @return {Promise} resolves to the update result. * @return {Promise} resolves to the update result.
*/ */
async adjustInventory(variantId, adjustment) { async adjustInventory(variantId, adjustment) {
//if variantId is undefined – ergo. a custom item – then do nothing // if variantId is undefined – ergo. a custom item – then do nothing
if (typeof variantId === "undefined" || variantId === null) { if (typeof variantId === "undefined" || variantId === null) {
return return
} }
return this.atomicPhase_(async manager => { return this.atomicPhase_(async (manager) => {
const variant = await this.productVariantService_.retrieve(variantId) const variant = await this.productVariantService_.retrieve(variantId)
//if inventory is managed then update // if inventory is managed then update
if (variant.manage_inventory) { if (variant.manage_inventory) {
return await this.productVariantService_ return await this.productVariantService_
.withTransaction(manager) .withTransaction(manager)
@@ -55,13 +55,13 @@ class InventoryService extends BaseService {
* Checks if the inventory of a variant can cover a given quantity. Will * Checks if the inventory of a variant can cover a given quantity. Will
* return true if the variant doesn't have managed inventory or if the variant * return true if the variant doesn't have managed inventory or if the variant
* allows backorders or if the inventory quantity is greater than `quantity`. * allows backorders or if the inventory quantity is greater than `quantity`.
* @params {string} variantId - the id of the variant to check * @param {string} variantId - the id of the variant to check
* @params {number} quantity - the number of units to check availability for * @param {number} quantity - the number of units to check availability for
* @return {boolean} true if the inventory covers the quantity * @return {boolean} true if the inventory covers the quantity
*/ */
async confirmInventory(variantId, quantity) { async confirmInventory(variantId, quantity) {
//if variantId is undefined then confirm inventory as it // if variantId is undefined then confirm inventory as it
//is a custom item that is not managed // is a custom item that is not managed
if (typeof variantId === "undefined" || variantId === null) { if (typeof variantId === "undefined" || variantId === null) {
return true return true
} }