cleanup: Eventbus, BP, Contentful, NotificationService (#292)

packages/medusa-plugin-brightpearl/src/api/index.js

@@ -22,10 +22,10 @@ export default (container) => {
 
   app.post("/brightpearl/goods-out", bodyParser.json(), async (req, res) => {
     const { id, lifecycle_event } = req.body
-    const brightpearlService = req.scope.resolve("brightpearlService")
+    const eventBusService = req.scope.resolve("eventBusService")
 
     if (lifecycle_event === "created") {
-      await brightpearlService.createFulfillmentFromGoodsOut(id)
+      eventBusService.emit("brightpearl.goods_out_note", { id })
     }
 
     res.sendStatus(200)

packages/medusa-plugin-brightpearl/src/services/brightpearl.js

@@ -1110,6 +1110,7 @@ class BrightpearlService extends BaseService {
   }
 
   async createFulfillmentFromGoodsOut(id) {
+    await this.manager_.transaction(async (m) => {
       const client = await this.getClient()
 
       // Get goods out and associated order
@@ -1146,19 +1147,26 @@ class BrightpearlService extends BaseService {
 
       if (partId) {
         if (partId.startsWith("claim")) {
-        return this.claimService_.createFulfillment(partId, {
+          return this.claimService_
+            .withTransaction(m)
+            .createFulfillment(partId, {
               goods_out_note: id,
             })
         } else {
-        return this.swapService_.createFulfillment(partId, {
+          return this.swapService_
+            .withTransaction(m)
+            .createFulfillment(partId, {
               goods_out_note: id,
             })
         }
       }
 
-    return this.orderService_.createFulfillment(order.externalRef, lines, {
+      return this.orderService_
+        .withTransaction(m)
+        .createFulfillment(order.externalRef, lines, {
           goods_out_note: id,
         })
+    }, "SERIALIZABLE")
   }
 
   async createCustomer(fromOrder) {

packages/medusa-plugin-brightpearl/src/subscribers/order.js

@@ -19,6 +19,11 @@ class OrderSubscriber {
 
     eventBusService.subscribe("order.placed", this.sendToBrightpearl)
 
+    eventBusService.subscribe(
+      "brightpearl.goods_out_note",
+      this.createFulfillmentFromGoodsOut
+    )
+
     eventBusService.subscribe("claim.created", this.registerClaim)
 
     eventBusService.subscribe("order.refund_created", this.registerRefund)
@@ -50,6 +55,10 @@ class OrderSubscriber {
     return this.brightpearlService_.createPayment(id)
   }
 
+  createFulfillmentFromGoodsOut = ({ id }) => {
+    return this.brightpearlService_.createFulfillmentFromGoodsOut(id)
+  }
+
   registerSwapPayment = async (data) => {
     return this.registerSwap({ id: data.id, swap_id: data.id })
   }

packages/medusa-plugin-contentful/src/services/contentful.js

@@ -297,9 +297,6 @@ class ContentfulService extends BaseService {
         }
       )
 
-      // const ignoreIds = (await this.getIgnoreIds_("product_variant")) || []
-      // ignoreIds.push(v.id)
-      // this.redis_.set("product_variant_ignore_ids", JSON.stringify(ignoreIds))
       return result
     } catch (error) {
       throw error
@@ -311,7 +308,7 @@ class ContentfulService extends BaseService {
       .then(() => true)
       .catch(() => false)
     if (!hasType) {
-      return
+      return Promise.resolve()
     }
     try {
       const r = await this.regionService_.retrieve(region.id, {
@@ -353,7 +350,7 @@ class ContentfulService extends BaseService {
       .then(() => true)
       .catch(() => false)
     if (!hasType) {
-      return
+      return Promise.resolve()
     }
 
     const updateFields = [
@@ -435,13 +432,13 @@ class ContentfulService extends BaseService {
 
     const found = data.fields.find((f) => updateFields.includes(f))
     if (!found) {
-      return
+      return Promise.resolve()
     }
 
     try {
       const ignore = await this.shouldIgnore_(data.id, "contentful")
       if (ignore) {
-        return
+        return Promise.resolve()
       }
 
       const p = await this.productService_.retrieve(data.id, {
@@ -594,14 +591,14 @@ class ContentfulService extends BaseService {
     if (variant.fields) {
       const found = variant.fields.find((f) => updateFields.includes(f))
       if (!found) {
-        return
+        return Promise.resolve()
       }
     }
 
     try {
       const ignore = await this.shouldIgnore_(variant.id, "contentful")
       if (ignore) {
-        return
+        return Promise.resolve()
       }
 
       const environment = await this.getContentfulEnvironment_()

packages/medusa-plugin-restock-notification/src/subscribers/index.js

@@ -19,6 +19,8 @@ class VariantSubscriber {
             .triggerRestock(id)
       )
     }
+
+    return Promise.resolve()
   }
 }
 

packages/medusa/src/services/notification.js

@@ -162,7 +162,7 @@ class NotificationService extends BaseService {
   handleEvent(eventName, data) {
     const subs = this.subscribers_[eventName]
     if (!subs) {
-      return
+      return Promise.resolve()
     }
 
     return Promise.all(

packages/medusa/src/services/order.js

@@ -110,10 +110,13 @@ class OrderService extends BaseService {
       shippingOptionService: this.shippingOptionService_,
       shippingProfileService: this.shippingProfileService_,
       fulfillmentProviderService: this.fulfillmentProviderService_,
+      fulfillmentService: this.fulfillmentService_,
+      customerService: this.customerService_,
       discountService: this.discountService_,
       totalsService: this.totalsService_,
       cartService: this.cartService_,
       giftCardService: this.giftCardService_,
+      addressRepository: this.addressRepository_,
       draftOrderService: this.draftOrderService_,
     })