From c684d16ec012a547a9981480db8b4b96f5f22904 Mon Sep 17 00:00:00 2001 From: Shahed Nasser Date: Thu, 17 Aug 2023 17:34:36 +0300 Subject: [PATCH] feat(create-medusa-app): remove `--stable` option and change to clone default branch (#4794) --- .changeset/olive-readers-fry.md | 5 +++++ .../create-medusa-app/src/commands/create.ts | 7 +------ packages/create-medusa-app/src/index.ts | 4 ---- .../create-medusa-app/src/utils/clone-repo.ts | 18 +++--------------- 4 files changed, 9 insertions(+), 25 deletions(-) create mode 100644 .changeset/olive-readers-fry.md diff --git a/.changeset/olive-readers-fry.md b/.changeset/olive-readers-fry.md new file mode 100644 index 0000000000..8dd7f4a175 --- /dev/null +++ b/.changeset/olive-readers-fry.md @@ -0,0 +1,5 @@ +--- +"create-medusa-app": minor +--- + +feat(create-medusa-app): remove `--stable` option and change to clone default branch diff --git a/packages/create-medusa-app/src/commands/create.ts b/packages/create-medusa-app/src/commands/create.ts index 17602092ec..ec9f4ee37c 100644 --- a/packages/create-medusa-app/src/commands/create.ts +++ b/packages/create-medusa-app/src/commands/create.ts @@ -31,7 +31,6 @@ export type CreateOptions = { seed?: boolean // commander passed --no-boilerplate as boilerplate boilerplate?: boolean - stable?: boolean skipDb?: boolean dbUrl?: string browser?: boolean @@ -43,7 +42,6 @@ export default async ({ repoUrl = "", seed, boilerplate, - stable, skipDb, dbUrl, browser, @@ -123,7 +121,6 @@ export default async ({ repoUrl, abortController, spinner, - stable, }) } catch { return @@ -217,9 +214,7 @@ export default async ({ resources: ["http://localhost:9000/health"], }).then(async () => open( - stable - ? "http://localhost:9000/store/products" - : inviteToken + inviteToken ? `http://localhost:7001/invite?token=${inviteToken}&first_run=true` : "http://localhost:7001" ) diff --git a/packages/create-medusa-app/src/index.ts b/packages/create-medusa-app/src/index.ts index 755ebbf81b..3fd716976c 100644 --- a/packages/create-medusa-app/src/index.ts +++ b/packages/create-medusa-app/src/index.ts @@ -10,10 +10,6 @@ program "--no-boilerplate", "Install a Medusa project without the boilerplate and demo files." ) - .option( - "--stable", - "Install the latest stable version. This removes all onboarding features" - ) .option( "--skip-db", "Skips creating the database, running migrations, and seeding, and subsequently skips opening the browser.", diff --git a/packages/create-medusa-app/src/utils/clone-repo.ts b/packages/create-medusa-app/src/utils/clone-repo.ts index 0e62fc7061..872237d987 100644 --- a/packages/create-medusa-app/src/utils/clone-repo.ts +++ b/packages/create-medusa-app/src/utils/clone-repo.ts @@ -9,7 +9,6 @@ type CloneRepoOptions = { directoryName?: string repoUrl?: string abortController?: AbortController - stable?: boolean } const DEFAULT_REPO = "https://github.com/medusajs/medusa-starter-default" @@ -18,14 +17,10 @@ export default async function cloneRepo({ directoryName = "", repoUrl, abortController, - stable = false, }: CloneRepoOptions) { - await promiseExec( - `git clone ${repoUrl || getRepoUrl(stable)} ${directoryName}`, - { - signal: abortController?.signal, - } - ) + await promiseExec(`git clone ${repoUrl || DEFAULT_REPO} ${directoryName}`, { + signal: abortController?.signal, + }) } export async function runCloneRepo({ @@ -33,20 +28,17 @@ export async function runCloneRepo({ repoUrl, abortController, spinner, - stable = false, }: { projectName: string repoUrl: string abortController: AbortController spinner: Ora - stable?: boolean }) { try { await cloneRepo({ directoryName: projectName, repoUrl, abortController, - stable, }) deleteGitDirectory(projectName) @@ -69,7 +61,3 @@ function deleteGitDirectory(projectDirectory: string) { force: true, }) } - -function getRepoUrl(stable?: boolean) { - return !stable ? `${DEFAULT_REPO} -b feat/onboarding` : DEFAULT_REPO -}