From c9234c2343e19b32b335b93f4fa53e54398a5fe6 Mon Sep 17 00:00:00 2001 From: Abdullah Pathan Date: Sun, 31 Oct 2021 03:55:58 -0400 Subject: [PATCH] fix: make api/routes/admin/apps pass eslint (#641) --- .eslintignore | 1 - .../src/api/routes/admin/apps/authorize-app.js | 18 +++++++----------- .../medusa/src/api/routes/admin/apps/index.js | 2 +- .../medusa/src/api/routes/admin/apps/list.js | 12 +++--------- .../src/api/routes/store/products/search.js | 4 +--- 5 files changed, 12 insertions(+), 25 deletions(-) diff --git a/.eslintignore b/.eslintignore index 14a1439d7e..4c3ea8964f 100644 --- a/.eslintignore +++ b/.eslintignore @@ -21,7 +21,6 @@ /packages/medusa/src/loaders/repositories.js /packages/medusa/src/loaders/services.js /packages/medusa/src/loaders/subscribers.js -/packages/medusa/src/api/routes/admin/apps /packages/medusa/src/api/routes/admin/auth /packages/medusa/src/api/routes/admin/collections /packages/medusa/src/api/routes/admin/notes diff --git a/packages/medusa/src/api/routes/admin/apps/authorize-app.js b/packages/medusa/src/api/routes/admin/apps/authorize-app.js index bd47844fb0..653ac9699a 100644 --- a/packages/medusa/src/api/routes/admin/apps/authorize-app.js +++ b/packages/medusa/src/api/routes/admin/apps/authorize-app.js @@ -11,15 +11,11 @@ export default async (req, res) => { if (error) { throw new MedusaError(MedusaError.Types.INVALID_DATA, error.details) } - try { - const oauthService = req.scope.resolve("oauthService") - const data = await oauthService.generateToken( - value.application_name, - value.code, - value.state - ) - res.status(200).json({ apps: data }) - } catch (err) { - throw err - } + const oauthService = req.scope.resolve("oauthService") + const data = await oauthService.generateToken( + value.application_name, + value.code, + value.state + ) + res.status(200).json({ apps: data }) } diff --git a/packages/medusa/src/api/routes/admin/apps/index.js b/packages/medusa/src/api/routes/admin/apps/index.js index 33af4ab43e..cdf43f8603 100644 --- a/packages/medusa/src/api/routes/admin/apps/index.js +++ b/packages/medusa/src/api/routes/admin/apps/index.js @@ -3,7 +3,7 @@ import middlewares from "../../../middlewares" const route = Router() -export default app => { +export default (app) => { app.use("/apps", route) route.get("/", middlewares.wrap(require("./list").default)) diff --git a/packages/medusa/src/api/routes/admin/apps/list.js b/packages/medusa/src/api/routes/admin/apps/list.js index bf925616f8..87d2c951bf 100644 --- a/packages/medusa/src/api/routes/admin/apps/list.js +++ b/packages/medusa/src/api/routes/admin/apps/list.js @@ -1,12 +1,6 @@ -import { MedusaError, Validator } from "medusa-core-utils" - export default async (req, res) => { - try { - const oauthService = req.scope.resolve("oauthService") - const data = await oauthService.list({}) + const oauthService = req.scope.resolve("oauthService") + const data = await oauthService.list({}) - res.status(200).json({ apps: data }) - } catch (err) { - throw err - } + res.status(200).json({ apps: data }) } diff --git a/packages/medusa/src/api/routes/store/products/search.js b/packages/medusa/src/api/routes/store/products/search.js index c21c95243f..387bf509e4 100644 --- a/packages/medusa/src/api/routes/store/products/search.js +++ b/packages/medusa/src/api/routes/store/products/search.js @@ -4,9 +4,7 @@ import ProductService from "../../../../services/product" export default async (req, res) => { const schema = Validator.object() .keys({ - q: Validator.string() - .required() - .allow(""), + q: Validator.string().required().allow(""), offset: Validator.number().optional(), limit: Validator.number().optional(), filter: Validator.any(),