fix(types, medusa): request / response types clean-up (#9043)

More clean-up of request / response types

packages/medusa/src/api/admin/fulfillments/[id]/cancel/route.ts

@@ -4,11 +4,10 @@ import {
   MedusaResponse,
 } from "../../../../../types/routing"
 import { refetchFulfillment } from "../../helpers"
-import { AdminCancelFulfillmentType } from "../../validators"
 import { HttpTypes } from "@medusajs/types"
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<AdminCancelFulfillmentType>,
+  req: AuthenticatedMedusaRequest,
   res: MedusaResponse<HttpTypes.AdminFulfillmentResponse>
 ) => {
   const { id } = req.params

packages/medusa/src/api/admin/fulfillments/middlewares.ts

@@ -3,7 +3,6 @@ import { validateAndTransformBody } from "../../utils/validate-body"
 import { validateAndTransformQuery } from "../../utils/validate-query"
 import * as QueryConfig from "./query-config"
 import {
-  AdminCancelFulfillment,
   AdminCreateFulfillment,
   AdminCreateShipment,
   AdminFulfillmentParams,
@@ -14,7 +13,6 @@ export const adminFulfillmentsRoutesMiddlewares: MiddlewareRoute[] = [
     method: ["POST"],
     matcher: "/admin/fulfillments/:id/cancel",
     middlewares: [
-      validateAndTransformBody(AdminCancelFulfillment),
       validateAndTransformQuery(
         AdminFulfillmentParams,
         QueryConfig.retrieveTransformQueryConfig

packages/medusa/src/api/admin/fulfillments/validators.ts

@@ -19,9 +19,6 @@ const AdminCreateFulfillmentLabel = z.object({
   label_url: z.string(),
 })
 
-export type AdminCancelFulfillmentType = z.infer<typeof AdminCancelFulfillment>
-export const AdminCancelFulfillment = z.object({})
-
 export type AdminCreateFulfillmentType = z.infer<typeof AdminCreateFulfillment>
 // TODO: revisit the data shape this endpoint accepts
 export const AdminCreateFulfillment = z.object({
@@ -30,7 +27,6 @@ export const AdminCreateFulfillment = z.object({
   delivery_address: AddressPayload,
   items: z.array(AdminCreateFulfillmentItem),
   labels: z.array(AdminCreateFulfillmentLabel),
-  order: z.object({}),
   order_id: z.string(),
   shipping_option_id: z.string().nullish(),
   data: z.record(z.unknown()).nullable(),

packages/medusa/src/api/admin/orders/[id]/archive/route.ts

@@ -7,18 +7,17 @@ import {
   AuthenticatedMedusaRequest,
   MedusaResponse,
 } from "../../../../../types/routing"
-import { AdminArchiveOrderType } from "../../validators"
 import { HttpTypes } from "@medusajs/types"
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<AdminArchiveOrderType>,
+  req: AuthenticatedMedusaRequest,
   res: MedusaResponse<HttpTypes.AdminOrderResponse>
 ) => {
   const remoteQuery = req.scope.resolve(ContainerRegistrationKeys.REMOTE_QUERY)
   const { id } = req.params
 
   await archiveOrderWorkflow(req.scope).run({
-    input: { orderIds: [req.validatedBody.order_id] },
+    input: { orderIds: [id] },
   })
 
   const queryObject = remoteQueryObjectFromString({

packages/medusa/src/api/admin/orders/middlewares.ts

@@ -3,7 +3,6 @@ import { validateAndTransformBody } from "../../utils/validate-body"
 import { validateAndTransformQuery } from "../../utils/validate-query"
 import * as QueryConfig from "./query-config"
 import {
-  AdminArchiveOrder,
   AdminCompleteOrder,
   AdminGetOrdersOrderParams,
   AdminGetOrdersParams,
@@ -58,7 +57,6 @@ export const adminOrderRoutesMiddlewares: MiddlewareRoute[] = [
     method: ["POST"],
     matcher: "/admin/orders/:id/archive",
     middlewares: [
-      validateAndTransformBody(AdminArchiveOrder),
       validateAndTransformQuery(
         AdminGetOrdersOrderParams,
         QueryConfig.retrieveTransformQueryConfig

packages/medusa/src/api/admin/orders/validators.ts

@@ -47,11 +47,6 @@ export const AdminGetOrdersParams = createFindParams({
 
 export type AdminGetOrdersParamsType = z.infer<typeof AdminGetOrdersParams>
 
-export const AdminArchiveOrder = z.object({
-  order_id: z.string(),
-})
-export type AdminArchiveOrderType = z.infer<typeof AdminArchiveOrder>
-
 export const AdminCompleteOrder = WithAdditionalData(z.object({}))
 
 const Item = z.object({