From cc1a37f2f5d03f1bd6d7fd5f4f4d06a5c704341c Mon Sep 17 00:00:00 2001 From: Shahed Nasser Date: Tue, 28 Oct 2025 11:04:27 +0200 Subject: [PATCH] chore: fixes to HTTP and request types for carts (#13821) --- .../medusa/src/api/store/carts/[id]/complete/route.ts | 2 +- .../medusa/src/api/store/carts/[id]/customer/route.ts | 2 +- .../api/store/carts/[id]/line-items/[line_id]/route.ts | 8 +++++--- .../medusa/src/api/store/carts/[id]/line-items/route.ts | 6 ++++-- .../medusa/src/api/store/carts/[id]/promotions/route.ts | 7 +++++-- packages/medusa/src/api/store/carts/[id]/route.ts | 8 +++++--- .../src/api/store/carts/[id]/shipping-methods/route.ts | 6 ++++-- packages/medusa/src/api/store/carts/[id]/taxes/route.ts | 2 +- packages/medusa/src/api/store/carts/route.ts | 5 ++++- 9 files changed, 30 insertions(+), 16 deletions(-) diff --git a/packages/medusa/src/api/store/carts/[id]/complete/route.ts b/packages/medusa/src/api/store/carts/[id]/complete/route.ts index 8f80320ece..ad8d78043a 100644 --- a/packages/medusa/src/api/store/carts/[id]/complete/route.ts +++ b/packages/medusa/src/api/store/carts/[id]/complete/route.ts @@ -11,7 +11,7 @@ import { refetchCart } from "../../helpers" import { defaultStoreCartFields } from "../../query-config" export const POST = async ( - req: MedusaRequest, + req: MedusaRequest<{}, HttpTypes.SelectParams>, res: MedusaResponse ) => { const cart_id = req.params.id diff --git a/packages/medusa/src/api/store/carts/[id]/customer/route.ts b/packages/medusa/src/api/store/carts/[id]/customer/route.ts index 89b1e04e5e..6fa46a35dc 100644 --- a/packages/medusa/src/api/store/carts/[id]/customer/route.ts +++ b/packages/medusa/src/api/store/carts/[id]/customer/route.ts @@ -10,7 +10,7 @@ import { refetchCart } from "../../helpers" import { AdditionalData } from "@medusajs/types" export const POST = async ( - req: AuthenticatedMedusaRequest, + req: AuthenticatedMedusaRequest, res: MedusaResponse ) => { const we = req.scope.resolve(Modules.WORKFLOW_ENGINE) diff --git a/packages/medusa/src/api/store/carts/[id]/line-items/[line_id]/route.ts b/packages/medusa/src/api/store/carts/[id]/line-items/[line_id]/route.ts index d83353ee9b..74796ca3cf 100644 --- a/packages/medusa/src/api/store/carts/[id]/line-items/[line_id]/route.ts +++ b/packages/medusa/src/api/store/carts/[id]/line-items/[line_id]/route.ts @@ -6,10 +6,12 @@ import { MedusaRequest, MedusaResponse } from "@medusajs/framework/http" import { AdditionalData, HttpTypes } from "@medusajs/framework/types" import { Modules } from "@medusajs/framework/utils" import { refetchCart } from "../../../helpers" -import { StoreUpdateCartLineItemType } from "../../../validators" export const POST = async ( - req: MedusaRequest, + req: MedusaRequest< + HttpTypes.StoreUpdateCartLineItem & AdditionalData, + HttpTypes.SelectParams + >, res: MedusaResponse ) => { const we = req.scope.resolve(Modules.WORKFLOW_ENGINE) @@ -33,7 +35,7 @@ export const POST = async ( } export const DELETE = async ( - req: MedusaRequest, + req: MedusaRequest<{}, HttpTypes.SelectParams>, res: MedusaResponse ) => { const id = req.params.line_id diff --git a/packages/medusa/src/api/store/carts/[id]/line-items/route.ts b/packages/medusa/src/api/store/carts/[id]/line-items/route.ts index 18007534ca..2c3a4c8190 100644 --- a/packages/medusa/src/api/store/carts/[id]/line-items/route.ts +++ b/packages/medusa/src/api/store/carts/[id]/line-items/route.ts @@ -3,11 +3,13 @@ import { MedusaRequest, MedusaResponse } from "@medusajs/framework/http" import { HttpTypes } from "@medusajs/framework/types" import { Modules } from "@medusajs/utils" import { refetchCart } from "../../helpers" -import { StoreAddCartLineItemType } from "../../validators" import { AdditionalData } from "@medusajs/types" export const POST = async ( - req: MedusaRequest, + req: MedusaRequest< + HttpTypes.StoreAddCartLineItem & AdditionalData, + HttpTypes.SelectParams + >, res: MedusaResponse ) => { const we = req.scope.resolve(Modules.WORKFLOW_ENGINE) diff --git a/packages/medusa/src/api/store/carts/[id]/promotions/route.ts b/packages/medusa/src/api/store/carts/[id]/promotions/route.ts index 4ade40d2e9..c79c971913 100644 --- a/packages/medusa/src/api/store/carts/[id]/promotions/route.ts +++ b/packages/medusa/src/api/store/carts/[id]/promotions/route.ts @@ -5,7 +5,10 @@ import { Modules, PromotionActions } from "@medusajs/framework/utils" import { refetchCart } from "../../helpers" export const POST = async ( - req: MedusaRequest, + req: MedusaRequest< + HttpTypes.StoreCartAddPromotion, + HttpTypes.SelectParams + >, res: MedusaResponse ) => { const we = req.scope.resolve(Modules.WORKFLOW_ENGINE) @@ -33,7 +36,7 @@ export const POST = async ( } export const DELETE = async ( - req: MedusaRequest, + req: MedusaRequest, res: MedusaResponse<{ cart: HttpTypes.StoreCart }> diff --git a/packages/medusa/src/api/store/carts/[id]/route.ts b/packages/medusa/src/api/store/carts/[id]/route.ts index 819d511132..1bf26546b6 100644 --- a/packages/medusa/src/api/store/carts/[id]/route.ts +++ b/packages/medusa/src/api/store/carts/[id]/route.ts @@ -2,7 +2,6 @@ import { updateCartWorkflowId } from "@medusajs/core-flows" import { AdditionalData, HttpTypes, - UpdateCartDataDTO, } from "@medusajs/framework/types" import { MedusaRequest, MedusaResponse } from "@medusajs/framework/http" @@ -10,7 +9,7 @@ import { Modules } from "@medusajs/framework/utils" import { refetchCart } from "../helpers" export const GET = async ( - req: MedusaRequest, + req: MedusaRequest, res: MedusaResponse ) => { const cart = await refetchCart( @@ -23,7 +22,10 @@ export const GET = async ( } export const POST = async ( - req: MedusaRequest, + req: MedusaRequest< + HttpTypes.StoreUpdateCart & AdditionalData, + HttpTypes.SelectParams + >, res: MedusaResponse<{ cart: HttpTypes.StoreCart }> diff --git a/packages/medusa/src/api/store/carts/[id]/shipping-methods/route.ts b/packages/medusa/src/api/store/carts/[id]/shipping-methods/route.ts index 741424d4ab..2bfcbe27ad 100644 --- a/packages/medusa/src/api/store/carts/[id]/shipping-methods/route.ts +++ b/packages/medusa/src/api/store/carts/[id]/shipping-methods/route.ts @@ -2,10 +2,12 @@ import { addShippingMethodToCartWorkflow } from "@medusajs/core-flows" import { MedusaRequest, MedusaResponse } from "@medusajs/framework/http" import { AdditionalData, HttpTypes } from "@medusajs/framework/types" import { refetchCart } from "../../helpers" -import { StoreAddCartShippingMethodsType } from "../../validators" export const POST = async ( - req: MedusaRequest, + req: MedusaRequest< + HttpTypes.StoreAddCartShippingMethods & AdditionalData, + HttpTypes.SelectParams + >, res: MedusaResponse ) => { const payload = req.validatedBody diff --git a/packages/medusa/src/api/store/carts/[id]/taxes/route.ts b/packages/medusa/src/api/store/carts/[id]/taxes/route.ts index bb54e2690c..46906e6ab0 100644 --- a/packages/medusa/src/api/store/carts/[id]/taxes/route.ts +++ b/packages/medusa/src/api/store/carts/[id]/taxes/route.ts @@ -4,7 +4,7 @@ import { HttpTypes } from "@medusajs/framework/types" import { refetchCart } from "../../helpers" export const POST = async ( - req: MedusaRequest, + req: MedusaRequest<{}, HttpTypes.SelectParams>, res: MedusaResponse ) => { await updateTaxLinesWorkflow(req.scope).run({ diff --git a/packages/medusa/src/api/store/carts/route.ts b/packages/medusa/src/api/store/carts/route.ts index 6c36ac43ff..960d89d734 100644 --- a/packages/medusa/src/api/store/carts/route.ts +++ b/packages/medusa/src/api/store/carts/route.ts @@ -11,7 +11,10 @@ import { import { refetchCart } from "./helpers" export const POST = async ( - req: AuthenticatedMedusaRequest, + req: AuthenticatedMedusaRequest< + HttpTypes.StoreCreateCart & AdditionalData, + HttpTypes.SelectParams + >, res: MedusaResponse ) => { const workflowInput = {