asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Use sub instead of email for google entity ID (#9949)

Browse Source
This commit is contained in:
Stevche Radevski
2024-11-07 09:24:14 +01:00
committed by GitHub
parent 242d00b567
commit cd578e89ff
3 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/modules/providers/auth-google/integration-tests/__tests__/services.spec.ts
View File

@@ -155,7 +155,7 @@ describe("Google auth provider", () => {
return {
provider_identities: [
{
entity_id: "test@admin.com",
entity_id: "113664482950786663866",
provider: "google",
},
],
@@ -180,7 +180,7 @@ describe("Google auth provider", () => {
authIdentity: {
provider_identities: [
{
entity_id: "test@admin.com",
entity_id: "113664482950786663866",
provider: "google",
},
],
@@ -194,7 +194,7 @@ describe("Google auth provider", () => {
return {
provider_identities: [
{
entity_id: "test@admin.com",
entity_id: "113664482950786663866",
provider: "google",
},
],
@@ -222,7 +222,7 @@ describe("Google auth provider", () => {
authIdentity: {
provider_identities: [
{
entity_id: "test@admin.com",
entity_id: "113664482950786663866",
provider: "google",
},
],

3
packages/modules/providers/auth-google/src/services/google.ts
View File

@@ -142,8 +142,7 @@ export class GoogleAuthService extends AbstractAuthModuleProvider {
)
}
// TODO: We should probably use something else than email here, like the `sub` field (which is more constant than the email)
const entity_id = payload.email
const entity_id = payload.sub
const userMetadata = {
name: payload.name,
picture: payload.picture,