From ce4d3616d733b5472ebfc00b49ab17c5aa53daef Mon Sep 17 00:00:00 2001 From: michizhou <33012425+michizhou@users.noreply.github.com> Date: Wed, 27 Oct 2021 00:15:46 -0700 Subject: [PATCH] fix: make packages/medusa/src/api/routes/admin/shipping-profiles pass eslint (#642) --- .eslintignore | 1 - .../create-shipping-profile.js | 10 +++------- .../delete-shipping-profile.js | 18 +++++++----------- .../shipping-profiles/get-shipping-profile.js | 16 ++++++---------- .../routes/admin/shipping-profiles/index.js | 2 +- .../list-shipping-profiles.js | 10 +++------- .../update-shipping-profile.js | 12 ++++-------- 7 files changed, 24 insertions(+), 45 deletions(-) diff --git a/.eslintignore b/.eslintignore index 2160a063cc..cd00ac214c 100644 --- a/.eslintignore +++ b/.eslintignore @@ -28,7 +28,6 @@ /packages/medusa/src/api/routes/admin/collections /packages/medusa/src/api/routes/admin/notes /packages/medusa/src/api/routes/admin/orders -/packages/medusa/src/api/routes/admin/shipping-profiles /packages/medusa/src/api/routes/admin/store /packages/medusa/src/api/routes/store/carts /packages/medusa/src/api/routes/store/return-reasons diff --git a/packages/medusa/src/api/routes/admin/shipping-profiles/create-shipping-profile.js b/packages/medusa/src/api/routes/admin/shipping-profiles/create-shipping-profile.js index 83da5b9dd4..2e9c3bef42 100644 --- a/packages/medusa/src/api/routes/admin/shipping-profiles/create-shipping-profile.js +++ b/packages/medusa/src/api/routes/admin/shipping-profiles/create-shipping-profile.js @@ -35,12 +35,8 @@ export default async (req, res) => { throw new MedusaError(MedusaError.Types.INVALID_DATA, error.details) } - try { - const profileService = req.scope.resolve("shippingProfileService") - const data = await profileService.create(value) + const profileService = req.scope.resolve("shippingProfileService") + const data = await profileService.create(value) - res.status(200).json({ shipping_profile: data }) - } catch (err) { - throw err - } + res.status(200).json({ shipping_profile: data }) } diff --git a/packages/medusa/src/api/routes/admin/shipping-profiles/delete-shipping-profile.js b/packages/medusa/src/api/routes/admin/shipping-profiles/delete-shipping-profile.js index e67e111f5f..92d1de5fb1 100644 --- a/packages/medusa/src/api/routes/admin/shipping-profiles/delete-shipping-profile.js +++ b/packages/medusa/src/api/routes/admin/shipping-profiles/delete-shipping-profile.js @@ -25,17 +25,13 @@ */ export default async (req, res) => { const { profile_id } = req.params - try { - const profileService = req.scope.resolve("shippingProfileService") + const profileService = req.scope.resolve("shippingProfileService") - await profileService.delete(profile_id) + await profileService.delete(profile_id) - res.status(200).json({ - id: profile_id, - object: "shipping_profile", - deleted: true, - }) - } catch (err) { - throw err - } + res.status(200).json({ + id: profile_id, + object: "shipping_profile", + deleted: true, + }) } diff --git a/packages/medusa/src/api/routes/admin/shipping-profiles/get-shipping-profile.js b/packages/medusa/src/api/routes/admin/shipping-profiles/get-shipping-profile.js index c2906710c7..04be482452 100644 --- a/packages/medusa/src/api/routes/admin/shipping-profiles/get-shipping-profile.js +++ b/packages/medusa/src/api/routes/admin/shipping-profiles/get-shipping-profile.js @@ -21,16 +21,12 @@ import { defaultFields, defaultRelations } from "./" */ export default async (req, res) => { const { profile_id } = req.params - try { - const profileService = req.scope.resolve("shippingProfileService") + const profileService = req.scope.resolve("shippingProfileService") - const profile = await profileService.retrieve(profile_id, { - select: defaultFields, - relations: defaultRelations, - }) + const profile = await profileService.retrieve(profile_id, { + select: defaultFields, + relations: defaultRelations, + }) - res.status(200).json({ shipping_profile: profile }) - } catch (err) { - throw err - } + res.status(200).json({ shipping_profile: profile }) } diff --git a/packages/medusa/src/api/routes/admin/shipping-profiles/index.js b/packages/medusa/src/api/routes/admin/shipping-profiles/index.js index aaf2b7901d..ed76ff2a14 100644 --- a/packages/medusa/src/api/routes/admin/shipping-profiles/index.js +++ b/packages/medusa/src/api/routes/admin/shipping-profiles/index.js @@ -3,7 +3,7 @@ import middlewares from "../../../middlewares" const route = Router() -export default app => { +export default (app) => { app.use("/shipping-profiles", route) route.get("/", middlewares.wrap(require("./list-shipping-profiles").default)) diff --git a/packages/medusa/src/api/routes/admin/shipping-profiles/list-shipping-profiles.js b/packages/medusa/src/api/routes/admin/shipping-profiles/list-shipping-profiles.js index 9c29ca36f6..ed2e249db9 100644 --- a/packages/medusa/src/api/routes/admin/shipping-profiles/list-shipping-profiles.js +++ b/packages/medusa/src/api/routes/admin/shipping-profiles/list-shipping-profiles.js @@ -18,13 +18,9 @@ * $ref: "#/components/schemas/shipping_profile" */ export default async (req, res) => { - try { - const profileService = req.scope.resolve("shippingProfileService") + const profileService = req.scope.resolve("shippingProfileService") - const data = await profileService.list() + const data = await profileService.list() - res.status(200).json({ shipping_profiles: data }) - } catch (err) { - throw err - } + res.status(200).json({ shipping_profiles: data }) } diff --git a/packages/medusa/src/api/routes/admin/shipping-profiles/update-shipping-profile.js b/packages/medusa/src/api/routes/admin/shipping-profiles/update-shipping-profile.js index de05c389af..8b0fd7a63f 100644 --- a/packages/medusa/src/api/routes/admin/shipping-profiles/update-shipping-profile.js +++ b/packages/medusa/src/api/routes/admin/shipping-profiles/update-shipping-profile.js @@ -39,14 +39,10 @@ export default async (req, res) => { throw new MedusaError(MedusaError.Types.INVALID_DATA, error.details) } - try { - const profileService = req.scope.resolve("shippingProfileService") + const profileService = req.scope.resolve("shippingProfileService") - await profileService.update(profile_id, value) + await profileService.update(profile_id, value) - const data = await profileService.retrieve(profile_id) - res.status(200).json({ shipping_profile: data }) - } catch (err) { - throw err - } + const data = await profileService.retrieve(profile_id) + res.status(200).json({ shipping_profile: data }) }