asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: re-add oas tests for generated OAS (#9036)

Browse Source 
* chore: re-add oas tests for generated OAS

* test fix
This commit is contained in:
Shahed Nasser
2024-09-07 09:01:22 +03:00
committed by GitHub
parent 7a80593b68
commit cf387aafa2
3 changed files with 45 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/cli/oas/medusa-oas-cli/src/__tests__/command-docs.test.ts
View File

@@ -208,7 +208,7 @@ describe("command docs", () => {
configFile = path.resolve(outDir, "redocly-config.json")
await writeJson(configFile, config)
configYamlFile = path.resolve(outDir, "redocly-config.yaml")
await writeYaml(configYamlFile, config)
await writeYaml(configYamlFile, JSON.stringify(config))
})
it("should fail with unhandled circular reference", async () => {

12
packages/cli/oas/medusa-oas-cli/src/command-docs.ts
View File

@@ -135,10 +135,12 @@ export async function execute(cliParams: OptionValues): Promise<void> {
const srcFileSanitized = path.resolve(tmpDir, "tmp.oas.yaml")
await sanitizeOAS(srcFile, srcFileSanitized, configTmpFile)
await fixCirclularReferences(srcFileSanitized, dryRun)
await fixCirclularReferences(srcFileSanitized)
if (dryRun) {
console.log(`⚫️ Dry run - no files generated`)
// check out possible changes in redocly config
await execa("git", ["checkout", path.join(basePath, "redocly", "redocly-config.yaml")])
return
}
if (shouldPreview) {
@@ -223,7 +225,7 @@ const sanitizeOAS = async (
console.log(logs)
}
const fixCirclularReferences = async (srcFile: string, dryRun = false): Promise<void> => {
const fixCirclularReferences = async (srcFile: string): Promise<void> => {
const { circularRefs, oas } = await getCircularReferences(srcFile)
if (circularRefs.length) {
const recommendation = getCircularPatchRecommendation(circularRefs, oas)
@@ -234,12 +236,6 @@ const fixCirclularReferences = async (srcFile: string, dryRun = false): Promise<
${hint}
###
`
if (dryRun) {
throw new Error(
`🔴 Unhandled circular references - Please manually patch using --config ./redocly-config.yaml
Within redocly-config.yaml, try adding the following:` + hintMessage
)
}
const redoclyConfigPath = path.join(basePath, "redocly", "redocly-config.yaml")
const originalContent = await readYaml(redoclyConfigPath) as CircularReferenceConfig
originalContent.decorators["medusa/circular-patch"].schemas = Object.assign(