asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(medusa): Delete ProductOption on Product without Variants (#1846)

Browse Source 
**What**
Solves admin issue [166](https://github.com/medusajs/admin/issues/166)

Deleting a product option on a product without variants currently throws, because we are cleaning up variant options as well.  

**How**
Only do variant clean up, if product has variants
This commit is contained in:
Oliver Windall Juhl
2022-08-29 18:51:45 +00:00
committed by GitHub
parent 37056b8066
commit d14a0398fb
3 changed files with 86 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/medusa/src/services/product.ts
+28 -23
View File
@@ -818,32 +818,37 @@ class ProductService extends TransactionBaseService {
return Promise.resolve()
}
// For the option we want to delete, make sure that all variants have the
// same option values. The reason for doing is, that we want to avoid
// duplicate variants. For example, if we have a product with size and
// color options, that has four variants: (black, 1), (black, 2),
// (blue, 1), (blue, 2) and we delete the size option from the product,
// we would end up with four variants: (black), (black), (blue), (blue).
// We now have two duplicate variants. To ensure that this does not
// happen, we will force the user to select which variants to keep.
const firstVariant = product.variants[0]
// In case the product does not contain variants, we can safely delete the option
// If it does contain variants, we need to make sure no variant exist for the
// product option to delete
if (product?.variants?.length) {
// For the option we want to delete, make sure that all variants have the
// same option values. The reason for doing is, that we want to avoid
// duplicate variants. For example, if we have a product with size and
// color options, that has four variants: (black, 1), (black, 2),
// (blue, 1), (blue, 2) and we delete the size option from the product,
// we would end up with four variants: (black), (black), (blue), (blue).
// We now have two duplicate variants. To ensure that this does not
// happen, we will force the user to select which variants to keep.
const firstVariant = product.variants[0]
const valueToMatch = firstVariant.options.find(
(o) => o.option_id === optionId
)?.value
const valueToMatch = firstVariant.options.find(
(o) => o.option_id === optionId
)?.value
const equalsFirst = await Promise.all(
product.variants.map(async (v) => {
const option = v.options.find((o) => o.option_id === optionId)
return option?.value === valueToMatch
})
)
if (!equalsFirst.every((v) => v)) {
throw new MedusaError(
MedusaError.Types.INVALID_DATA,
`To delete an option, first delete all variants, such that when an option is deleted, no duplicate variants will exist.`
const equalsFirst = await Promise.all(
product.variants.map(async (v) => {
const option = v.options.find((o) => o.option_id === optionId)
return option?.value === valueToMatch
})
)
if (!equalsFirst.every((v) => v)) {
throw new MedusaError(
MedusaError.Types.INVALID_DATA,
`To delete an option, first delete all variants, such that when an option is deleted, no duplicate variants will exist.`
)
}
}
// If we reach this point, we can safely delete the product option