Revert "feat(core-flows,medusa): Add customer validation on cart update" (#9724)

packages/core/core-flows/src/cart/workflows/index.ts

@@ -8,6 +8,5 @@ export * from "./list-shipping-options-for-cart"
 export * from "./refresh-payment-collection"
 export * from "./update-cart"
 export * from "./update-cart-promotions"
-export * from "./update-cart-with-customer-validation"
 export * from "./update-line-item-in-cart"
 export * from "./update-tax-lines"

packages/core/core-flows/src/cart/workflows/update-cart-with-customer-validation.ts

@@ -1,90 +0,0 @@
-import {
-  AdditionalData,
-  UpdateCartWorkflowInputDTO,
-} from "@medusajs/framework/types"
-import { isDefined, isPresent, MedusaError } from "@medusajs/framework/utils"
-import {
-  createStep,
-  createWorkflow,
-  when,
-  WorkflowData,
-  WorkflowResponse,
-} from "@medusajs/framework/workflows-sdk"
-import { useRemoteQueryStep } from "../../common"
-import { updateCartWorkflow } from "./update-cart"
-
-/**
- * This step validates rules of engagement when customer_id or email is
- * requested to be updated.
- */
-export const validateCartCustomerOrEmailStep = createStep(
-  "validate-cart-customer-or-email",
-  async function ({
-    input,
-    cart,
-  }: {
-    input: {
-      customer_id?: string | null
-      email?: string | null
-      auth_customer_id: string | undefined | null
-    }
-    cart: { customer_id: string | null; email: string | null }
-  }) {
-    if (isPresent(cart.customer_id) && cart.customer_id !== input.customer_id) {
-      throw new MedusaError(
-        MedusaError.Types.INVALID_DATA,
-        `Cannot update cart customer when customer_id is set`
-      )
-    }
-
-    if (isDefined(input.customer_id) && !isDefined(input.auth_customer_id)) {
-      throw new MedusaError(
-        MedusaError.Types.INVALID_DATA,
-        `auth_customer_id is required when customer_id is set`
-      )
-    }
-
-    const isInputCustomerIdDifferent =
-      input.auth_customer_id !== input.customer_id
-
-    if (isDefined(input.customer_id) && isInputCustomerIdDifferent) {
-      throw new MedusaError(
-        MedusaError.Types.INVALID_DATA,
-        `Cannot update cart customer_id to a different customer`
-      )
-    }
-  }
-)
-
-export const updateCartWorkflowWithCustomerValidationId =
-  "update-cart-with-customer-validation"
-/**
- * This workflow wraps updateCartWorkflow with customer validations
- */
-export const updateCartWorkflowWithCustomerValidation = createWorkflow(
-  updateCartWorkflowWithCustomerValidationId,
-  (
-    input: WorkflowData<
-      UpdateCartWorkflowInputDTO &
-        AdditionalData & { auth_customer_id: string | undefined }
-    >
-  ) => {
-    const cart = useRemoteQueryStep({
-      entry_point: "cart",
-      variables: { id: input.id },
-      fields: ["id", "customer_id", "email"],
-      list: false,
-      throw_if_key_not_found: true,
-    }).config({ name: "get-cart" })
-
-    when({ input }, ({ input }) => {
-      return !!input.customer_id || !!input.email
-    }).then(() => {
-      validateCartCustomerOrEmailStep({ input, cart })
-    })
-
-    const updatedCart = updateCartWorkflow.runAsStep({ input })
-
-    return new WorkflowResponse(updatedCart)
-  }
-)

packages/medusa/src/api/store/carts/[id]/route.ts

@@ -1,15 +1,11 @@
-import { updateCartWorkflowWithCustomerValidation } from "@medusajs/core-flows"
+import { updateCartWorkflow } from "@medusajs/core-flows"
 import {
   AdditionalData,
   HttpTypes,
   UpdateCartDataDTO,
 } from "@medusajs/framework/types"
 
-import {
-  AuthenticatedMedusaRequest,
-  MedusaRequest,
-  MedusaResponse,
-} from "@medusajs/framework/http"
+import { MedusaRequest, MedusaResponse } from "@medusajs/framework/http"
 import { refetchCart } from "../helpers"
 
 export const GET = async (
@@ -26,15 +22,17 @@ export const GET = async (
 }
 
 export const POST = async (
-  req: AuthenticatedMedusaRequest<UpdateCartDataDTO & AdditionalData>,
-  res: MedusaResponse<HttpTypes.StoreCartResponse>
+  req: MedusaRequest<UpdateCartDataDTO & AdditionalData>,
+  res: MedusaResponse<{
+    cart: HttpTypes.StoreCart
+  }>
 ) => {
-  const workflow = updateCartWorkflowWithCustomerValidation(req.scope)
+  const workflow = updateCartWorkflow(req.scope)
+
   await workflow.run({
     input: {
       ...req.validatedBody,
       id: req.params.id,
-      auth_customer_id: req.auth_context?.actor_id,
     },
   })
 

packages/medusa/src/api/store/carts/validators.ts

@@ -46,7 +46,6 @@ export const StoreRemoveCartPromotions = z
 export type StoreUpdateCartType = z.infer<typeof UpdateCart>
 export const UpdateCart = z
   .object({
-    customer_id: z.string().optional(),
     region_id: z.string().optional(),
     email: z.string().email().nullish(),
     billing_address: z.union([AddressPayload, z.string()]).optional(),