diff --git a/.changeset/brave-students-sneeze.md b/.changeset/brave-students-sneeze.md new file mode 100644 index 0000000000..77452125b9 --- /dev/null +++ b/.changeset/brave-students-sneeze.md @@ -0,0 +1,7 @@ +--- +"@medusajs/dashboard": patch +"@medusajs/js-sdk": patch +"@medusajs/types": patch +--- + +fix(dashboard,js-sdk,types): Remove redundant body for markAsDelivered diff --git a/packages/admin/dashboard/src/hooks/api/orders.tsx b/packages/admin/dashboard/src/hooks/api/orders.tsx index 4440bb7942..3559f96687 100644 --- a/packages/admin/dashboard/src/hooks/api/orders.tsx +++ b/packages/admin/dashboard/src/hooks/api/orders.tsx @@ -259,12 +259,11 @@ export const useMarkOrderFulfillmentAsDelivered = ( options?: UseMutationOptions< { order: HttpTypes.AdminOrder }, FetchError, - HttpTypes.AdminMarkOrderFulfillmentAsDelivered + void > ) => { return useMutation({ - mutationFn: (payload: HttpTypes.AdminMarkOrderFulfillmentAsDelivered) => - sdk.admin.order.markAsDelivered(orderId, fulfillmentId, payload), + mutationFn: () => sdk.admin.order.markAsDelivered(orderId, fulfillmentId), onSuccess: (data: any, variables: any, context: any) => { queryClient.invalidateQueries({ queryKey: ordersQueryKeys.all, diff --git a/packages/admin/dashboard/src/routes/orders/order-detail/components/order-fulfillment-section/order-fulfillment-section.tsx b/packages/admin/dashboard/src/routes/orders/order-detail/components/order-fulfillment-section/order-fulfillment-section.tsx index 69e521a58e..30e5d8f4f7 100644 --- a/packages/admin/dashboard/src/routes/orders/order-detail/components/order-fulfillment-section/order-fulfillment-section.tsx +++ b/packages/admin/dashboard/src/routes/orders/order-detail/components/order-fulfillment-section/order-fulfillment-section.tsx @@ -265,17 +265,14 @@ const Fulfillment = ({ }) if (res) { - await markAsDelivered( - {}, - { - onSuccess: () => { - toast.success(t("orders.fulfillment.toast.fulfillmentDelivered")) - }, - onError: (e) => { - toast.error(e.message) - }, - } - ) + await markAsDelivered(undefined, { + onSuccess: () => { + toast.success(t("orders.fulfillment.toast.fulfillmentDelivered")) + }, + onError: (e) => { + toast.error(e.message) + }, + }) } } diff --git a/packages/core/js-sdk/src/admin/order.ts b/packages/core/js-sdk/src/admin/order.ts index 096a31ef49..73200aa8ff 100644 --- a/packages/core/js-sdk/src/admin/order.ts +++ b/packages/core/js-sdk/src/admin/order.ts @@ -1,10 +1,10 @@ import { + AdminOrderChangesResponse, FindParams, HttpTypes, PaginatedResponse, SelectParams, } from "@medusajs/types" -import { AdminOrderChangesResponse } from "@medusajs/types" import { Client } from "../client" import { ClientHeaders } from "../types" @@ -411,7 +411,6 @@ export class Order { * * @param id - The order's ID. * @param fulfillmentId - The fulfillment's ID. - * @param body - The delivery details. * @param query - Configure the fields to retrieve in the order. * @param headers - Headers to pass in the request * @returns The order's details. @@ -420,7 +419,6 @@ export class Order { * sdk.admin.order.markAsDelivered( * "order_123", * "ful_123", - * {} * ) * .then(({ order }) => { * console.log(order) @@ -429,7 +427,6 @@ export class Order { async markAsDelivered( id: string, fulfillmentId: string, - body: HttpTypes.AdminMarkOrderFulfillmentAsDelivered, query?: SelectParams, headers?: ClientHeaders ) { @@ -438,7 +435,6 @@ export class Order { { method: "POST", headers, - body, query, } ) diff --git a/packages/core/types/src/http/order/admin/payload.ts b/packages/core/types/src/http/order/admin/payload.ts index d0f601318a..c9d0a75be8 100644 --- a/packages/core/types/src/http/order/admin/payload.ts +++ b/packages/core/types/src/http/order/admin/payload.ts @@ -90,8 +90,6 @@ export interface AdminCancelOrderFulfillment { no_notification?: boolean } -export interface AdminMarkOrderFulfillmentAsDelivered {} - export interface AdminRequestOrderTransfer { customer_id: string internal_note?: string