asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(core-flows): refresh payment collection inside updateCartPromotionsWorkflow (patch) (#14274)

Browse Source 
* Refresh payment collection after cart promotion update

* Add missing test

* Add changeset

* Update changeset

* Add force_refresh_payment_collection to updateCartPromotionsWorkflow to conditionally refresh payment collection

* Prevent refreshing payment collection multiple times

* Fix test

* Formatting and unused vars

* Force refresh payment collection on dedicated store cart promotion endpoints

---------

Co-authored-by: Adrien de Peretti <adrien.deperetti@gmail.com>
Co-authored-by: Oli Juhl <59018053+olivermrbl@users.noreply.github.com>
This commit is contained in:
Nicolas Gorga
2025-12-11 06:29:52 -03:00
committed by GitHub
parent a78f68fa46
commit d565a92f63
2 changed files with 89 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

92
integration-tests/http/__tests__/cart/store/cart.spec.ts
View File

@@ -5299,6 +5299,73 @@ medusaIntegrationTestRunner({
})
})
describe("POST /store/carts/:id/promotions", () => {
it("should add promotions and refresh payment collection", async () => {
cart = (
await api.post(
`/store/carts`,
{
currency_code: "usd",
sales_channel_id: salesChannel.id,
region_id: region.id,
shipping_address: shippingAddressData,
items: [{ variant_id: product.variants[0].id, quantity: 1 }],
},
storeHeaders
)
).data.cart
const paymentCollection = (
await api.post(
`/store/payment-collections`,
{ cart_id: cart.id },
storeHeaders
)
).data.payment_collection
await api.post(
`/store/payment-collections/${paymentCollection.id}/payment-sessions`,
{ provider_id: "pp_system_default" },
storeHeaders
)
cart = (await api.get(`/store/carts/${cart.id}`, storeHeaders)).data
.cart
expect(cart.total).toEqual(1500)
expect(cart.payment_collection.amount).toEqual(1500)
const cartAfterPromotion = (
await api.post(
`/store/carts/${cart.id}/promotions`,
{ promo_codes: [promotion.code] },
storeHeaders
)
).data.cart
expect(cartAfterPromotion).toEqual(
expect.objectContaining({
id: cart.id,
total: 1395,
discount_total: 105,
payment_collection: expect.objectContaining({
amount: 1395,
}),
items: expect.arrayContaining([
expect.objectContaining({
adjustments: expect.arrayContaining([
expect.objectContaining({
code: "PROMOTION_APPLIED",
promotion_id: promotion.id,
amount: 100,
}),
]),
}),
]),
})
)
})
})
describe("DELETE /store/carts/:id/promotions", () => {
it("should remove promotions and recalculate payment_collection amount", async () => {
cart = (
@@ -5316,9 +5383,17 @@ medusaIntegrationTestRunner({
)
).data.cart
const paymentCollection = await api
.post(
`/store/payment-collections`,
{ cart_id: cart.id },
storeHeaders
)
.then((response) => response.data.payment_collection)
await api.post(
`/store/payment-collections`,
{ cart_id: cart.id },
`/store/payment-collections/${paymentCollection.id}/payment-sessions`,
{ provider_id: "pp_system_default" },
storeHeaders
)
@@ -5328,6 +5403,11 @@ medusaIntegrationTestRunner({
expect(cart).toEqual(
expect.objectContaining({
id: cart.id,
total: 1395,
discount_total: 105,
payment_collection: expect.objectContaining({
amount: 1395,
}),
items: expect.arrayContaining([
expect.objectContaining({
adjustments: expect.arrayContaining([
@@ -5352,6 +5432,11 @@ medusaIntegrationTestRunner({
expect(cartAfterDeletion).toEqual(
expect.objectContaining({
id: cart.id,
total: 1500,
discount_total: 0,
payment_collection: expect.objectContaining({
amount: 1500,
}),
items: expect.arrayContaining([
expect.objectContaining({
adjustments: [],
@@ -5359,9 +5444,6 @@ medusaIntegrationTestRunner({
]),
})
)
expect(cartAfterDeletion.total).toEqual(1500)
expect(cartAfterDeletion.discount_total).toEqual(0)
})
})