From d9fdabe96d05108355c01081ea15d39467e40268 Mon Sep 17 00:00:00 2001 From: Harminder Virk Date: Tue, 20 May 2025 20:21:51 +0530 Subject: [PATCH] fix: mark posthog-node as a peer dependency (#12539) Since the runtime of the `@medusajs/analytics-posthog` relies on `posthog-node` package. It should be either installed as a dependency or a peerDependency that will be satisfied by the user project. In this PR, I have added it as a peer dependency --- .changeset/empty-peas-cheer.md | 6 ++++++ packages/medusa/package.json | 4 ++++ packages/modules/providers/analytics-posthog/package.json | 3 ++- yarn.lock | 4 ++++ 4 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 .changeset/empty-peas-cheer.md diff --git a/.changeset/empty-peas-cheer.md b/.changeset/empty-peas-cheer.md new file mode 100644 index 0000000000..e072b0516b --- /dev/null +++ b/.changeset/empty-peas-cheer.md @@ -0,0 +1,6 @@ +--- +"@medusajs/medusa": patch +"@medusajs/analytics-posthog": patch +--- + +fix: mark posthog-node as a peer dependency diff --git a/packages/medusa/package.json b/packages/medusa/package.json index 5e211974cd..ebecaf01c7 100644 --- a/packages/medusa/package.json +++ b/packages/medusa/package.json @@ -140,6 +140,7 @@ "@opentelemetry/sdk-trace-node": "^2.0.0", "@swc/core": "1.5.7", "awilix": "^8.0.1", + "posthog-node": "^4.17.1", "react-dom": "^18.0.0", "yalc": "1.0.0-pre.53" }, @@ -159,6 +160,9 @@ "@swc/core": { "optional": true }, + "posthog-node": { + "optional": true + }, "react-dom": { "optional": true }, diff --git a/packages/modules/providers/analytics-posthog/package.json b/packages/modules/providers/analytics-posthog/package.json index cf38d2e0aa..769397b133 100644 --- a/packages/modules/providers/analytics-posthog/package.json +++ b/packages/modules/providers/analytics-posthog/package.json @@ -34,7 +34,8 @@ "typescript": "^5.6.2" }, "peerDependencies": { - "@medusajs/framework": "2.8.2" + "@medusajs/framework": "2.8.2", + "posthog-node": "^4.17.1" }, "keywords": [ "medusa-plugin", diff --git a/yarn.lock b/yarn.lock index 7cce2a74f4..2f2b1526d4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5848,6 +5848,7 @@ __metadata: typescript: ^5.6.2 peerDependencies: "@medusajs/framework": 2.8.2 + posthog-node: ^4.17.1 languageName: unknown linkType: soft @@ -6722,6 +6723,7 @@ __metadata: "@opentelemetry/sdk-trace-node": ^2.0.0 "@swc/core": 1.5.7 awilix: ^8.0.1 + posthog-node: ^4.17.1 react-dom: ^18.0.0 yalc: 1.0.0-pre.53 peerDependenciesMeta: @@ -6735,6 +6737,8 @@ __metadata: optional: true "@swc/core": optional: true + posthog-node: + optional: true react-dom: optional: true yalc: