asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Unique constraint should account for soft deleted records (#11048)

Browse Source 
FIXES FRMW-2878

**What**
Currently, the `one-to-one` unique constraints does not account for deleted record. This prevents from inserting a new record wth the same fk if another one is deleted.

**Caveat**
`hasOne` with FK option is meant to be a special case, for example a many to one - one to many without defining the other side of the relation. In that case we don't handle this behaviour and keep it as it is
This commit is contained in:
Adrien de Peretti
2025-01-22 08:42:06 +01:00
committed by GitHub
parent ecc8efcb04
commit da3906efa4
22 changed files with 361 additions and 217 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/modules/workflow-engine-redis/src/migrations/.snapshot-medusa-workflows.json
View File

@@ -137,6 +137,14 @@
"unique": false,
"expression": "CREATE INDEX IF NOT EXISTS \"IDX_workflow_execution_transaction_id\" ON \"workflow_execution\" (transaction_id) WHERE deleted_at IS NULL"
},
{
"keyName": "IDX_workflow_execution_workflow_id_transaction_id_unique",
"columnNames": [],
"composite": false,
"primary": false,
"unique": false,
"expression": "CREATE UNIQUE INDEX IF NOT EXISTS \"IDX_workflow_execution_workflow_id_transaction_id_unique\" ON \"workflow_execution\" (workflow_id, transaction_id) WHERE deleted_at IS NULL"
},
{
"keyName": "IDX_workflow_execution_state",
"columnNames": [],

13
packages/modules/workflow-engine-redis/src/migrations/Migration20250120111059.ts Normal file
View File

@@ -0,0 +1,13 @@
import { Migration } from '@mikro-orm/migrations';
export class Migration20250120111059 extends Migration {
async up(): Promise<void> {
this.addSql('CREATE UNIQUE INDEX IF NOT EXISTS "IDX_workflow_execution_workflow_id_transaction_id_unique" ON "workflow_execution" (workflow_id, transaction_id) WHERE deleted_at IS NULL;');
}
async down(): Promise<void> {
this.addSql('drop index if exists "IDX_workflow_execution_workflow_id_transaction_id_unique";');
}
}

5
packages/modules/workflow-engine-redis/src/models/workflow-execution.ts
View File

@@ -23,6 +23,11 @@ export const WorkflowExecution = model
on: ["transaction_id"],
where: "deleted_at IS NULL",
},
{
on: ["workflow_id", "transaction_id"],
unique: true,
where: "deleted_at IS NULL",
},
{
on: ["state"],
where: "deleted_at IS NULL",