chore(modules-sdk): Custom Module definition (#7315)

packages/core/modules-sdk/src/definitions.ts

@@ -96,7 +96,6 @@ export const ModulesDefinition: { [key: string | Modules]: ModuleDefinition } =
   {
     [Modules.EVENT_BUS]: {
       key: Modules.EVENT_BUS,
-      isLegacy: true,
       registrationName: ModuleRegistrationName.EVENT_BUS,
       defaultPackage: MODULE_PACKAGE_NAMES[Modules.EVENT_BUS],
       label: upperCaseFirst(ModuleRegistrationName.EVENT_BUS),
@@ -109,7 +108,6 @@ export const ModulesDefinition: { [key: string | Modules]: ModuleDefinition } =
     },
     [Modules.STOCK_LOCATION]: {
       key: Modules.STOCK_LOCATION,
-      isLegacy: true,
       registrationName: ModuleRegistrationName.STOCK_LOCATION,
       defaultPackage: false,
       label: upperCaseFirst(ModuleRegistrationName.STOCK_LOCATION),
@@ -123,7 +121,6 @@ export const ModulesDefinition: { [key: string | Modules]: ModuleDefinition } =
     },
     [Modules.INVENTORY]: {
       key: Modules.INVENTORY,
-      isLegacy: true,
       registrationName: ModuleRegistrationName.INVENTORY,
       defaultPackage: false,
       label: upperCaseFirst(ModuleRegistrationName.INVENTORY),
@@ -137,7 +134,6 @@ export const ModulesDefinition: { [key: string | Modules]: ModuleDefinition } =
     },
     [Modules.CACHE]: {
       key: Modules.CACHE,
-      isLegacy: true,
       registrationName: ModuleRegistrationName.CACHE,
       defaultPackage: MODULE_PACKAGE_NAMES[Modules.CACHE],
       label: upperCaseFirst(ModuleRegistrationName.CACHE),

packages/core/modules-sdk/src/loaders/__tests__/register-modules.ts

@@ -16,7 +16,6 @@ describe("module definitions loader", () => {
     registrationName: "testService",
     defaultPackage: "@medusajs/test-service",
     label: "TestService",
-    isLegacy: true,
     isRequired: false,
     defaultModuleDeclaration: {
       scope: MODULE_SCOPE.INTERNAL,

packages/core/modules-sdk/src/loaders/module-loader.ts

@@ -55,6 +55,13 @@ async function loadModule(
   loaderOnly?: boolean
 ): Promise<{ error?: Error } | void> {
   const modDefinition = resolution.definition
+
+  if (!modDefinition.key) {
+    throw new Error(`Module definition is missing property "key"`)
+  }
+
+  modDefinition.registrationName ??= modDefinition.key
+
   const registrationName = modDefinition.registrationName
 
   const { scope, resources } = resolution.moduleDeclaration ?? ({} as any)