From e3a0df3ba0256f1774dc85dc97d1007190126e53 Mon Sep 17 00:00:00 2001 From: Stevche Radevski Date: Tue, 2 Jul 2024 15:13:00 +0200 Subject: [PATCH] fix: Prefix the job workflow names with `job` (#7908) --- .../src/loaders/__fixtures__/plugin/jobs/order-summary.ts | 2 +- packages/medusa/src/loaders/__tests__/register-jobs.spec.ts | 2 +- packages/medusa/src/loaders/helpers/register-jobs.ts | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/medusa/src/loaders/__fixtures__/plugin/jobs/order-summary.ts b/packages/medusa/src/loaders/__fixtures__/plugin/jobs/order-summary.ts index b74b773413..ac8e4fbe5a 100644 --- a/packages/medusa/src/loaders/__fixtures__/plugin/jobs/order-summary.ts +++ b/packages/medusa/src/loaders/__fixtures__/plugin/jobs/order-summary.ts @@ -5,7 +5,7 @@ export default async function handler(container: MedusaContainer) { } export const config = { - name: "summarize-orders-job", + name: "summarize-orders", schedule: "* * * * * *", numberOfExecutions: 2, } diff --git a/packages/medusa/src/loaders/__tests__/register-jobs.spec.ts b/packages/medusa/src/loaders/__tests__/register-jobs.spec.ts index 9a6443a668..ce4539394c 100644 --- a/packages/medusa/src/loaders/__tests__/register-jobs.spec.ts +++ b/packages/medusa/src/loaders/__tests__/register-jobs.spec.ts @@ -9,7 +9,7 @@ describe("register jobs", () => { await registerJobs([ { resolve: path.join(__dirname, "../__fixtures__/plugin") }, ]) - const workflow = WorkflowManager.getWorkflow("summarize-orders-job") + const workflow = WorkflowManager.getWorkflow("job-summarize-orders") expect(workflow).toBeDefined() expect(workflow?.options.schedule).toEqual({ cron: "* * * * * *", diff --git a/packages/medusa/src/loaders/helpers/register-jobs.ts b/packages/medusa/src/loaders/helpers/register-jobs.ts index 4ec1c37e82..a98b25aa59 100644 --- a/packages/medusa/src/loaders/helpers/register-jobs.ts +++ b/packages/medusa/src/loaders/helpers/register-jobs.ts @@ -45,6 +45,7 @@ export const registerJobs = async (plugins) => { } const createJob = async ({ config, handler }) => { + const workflowName = `job-${config.name}` const step = createStep( `${config.name}-as-step`, async (stepInput, stepContext) => { @@ -56,7 +57,7 @@ const createJob = async ({ config, handler }) => { createWorkflow( { - name: config.name, + name: workflowName, schedule: { cron: config.schedule, numberOfExecutions: config.numberOfExecutions,