chore(orchestration): prevent throwing on already defined workflow (#5337)

**What**
At the moment, when importing something from medusa entry point, if two medusa packages are installed because of a plugin, the evaluation of the import can end up throwing that a workflow is already defined. To prevent that from happening, we can just not throw if it is already defined and just return prematurely and make it idempotent.
This commit is contained in:
Adrien de Peretti
2023-10-18 11:47:22 +02:00
committed by GitHub
parent a1807aea83
commit e47461d95c
6 changed files with 120 additions and 4 deletions

View File

@@ -0,0 +1,33 @@
import { deepEqualObj } from "../deep-equal-obj"
describe("deepEqualObj", function () {
it("should return true if objects are equal", function () {
const object1 = {
foo: "bar",
bar: "foo",
xar: { foo: "bar", wor: { bar: "foo", ror: ["test", "test1"] } },
}
const object2 = {
foo: "bar",
bar: "foo",
xar: { foo: "bar", wor: { bar: "foo", ror: ["test", "test1"] } },
}
expect(deepEqualObj(object1, object2)).toBe(true)
})
it("should return false if objects are not equal", function () {
const object1 = {
foo: "bar",
bar: "foo",
xar: { foo: "bar", wor: { bar: "foo", ror: ["test", "test1"] } },
}
const object2 = {
foo: "bar",
bar: "foo",
xar: { foo: "bar", wor: { bar: "foo", ror: ["test", "test1_"] } },
}
expect(deepEqualObj(object1, object2)).toBe(false)
})
})

View File

@@ -0,0 +1,24 @@
export function deepEqualObj(obj1: object, obj2: object): boolean {
if (typeof obj1 !== typeof obj2) {
return false
}
if (typeof obj1 !== "object" || obj1 === null) {
return obj1 === obj2
}
const obj1Keys = Object.keys(obj1)
const obj2Keys = Object.keys(obj2)
if (obj1Keys.length !== obj2Keys.length) {
return false
}
for (const key of obj1Keys) {
if (!obj2Keys.includes(key) || !deepEqualObj(obj1[key], obj2[key])) {
return false
}
}
return true
}

View File

@@ -29,3 +29,4 @@ export * from "./to-pascal-case"
export * from "./transaction"
export * from "./upper-case-first"
export * from "./wrap-handler"
export * from "./deep-equal-obj"