chore: fix integration tests (#1240)

* chore: fix integration tests

* chore: fix integration tests

* fix: store tests

* fix: store tests

* fix: cleanup

packages/medusa/src/api/middlewares/error-handler.js

@@ -32,7 +32,7 @@ export default () => {
           "The request conflicted with another request. You may retry the request with the provided Idempotency-Key."
         break
       case MedusaError.Types.DUPLICATE_ERROR:
-        statusCode = 402
+        statusCode = 422
         errObj.code = INVALID_REQUEST_ERROR
         break
       case MedusaError.Types.NOT_ALLOWED:

packages/medusa/src/api/routes/admin/store/get-store.ts

@@ -31,6 +31,7 @@ export default async (req, res) => {
     req.scope.resolve("fulfillmentProviderService")
 
   const data = await storeService.retrieve(["currencies", "default_currency"])
+
   const paymentProviders = await paymentProviderService.list()
   const fulfillmentProviders = await fulfillmentProviderService.list()
 

packages/medusa/src/loaders/defaults.js

@@ -67,7 +67,7 @@ export default async ({ container }) => {
     const currencyRepo = manager.getCustomRepository(currencyRepository)
     const hasCurrencies = await currencyRepo.findOne()
     if (!hasCurrencies) {
-      for (const [_, c] of Object.entries(currencies)) {
+      for (const [, c] of Object.entries(currencies)) {
         const query = `INSERT INTO "currency" ("code", "symbol", "symbol_native", "name") VALUES ($1, $2, $3, $4)`
 
         const code = c.code.toLowerCase()
@@ -83,40 +83,37 @@ export default async ({ container }) => {
   await entityManager.transaction(async (manager) => {
     await storeService.withTransaction(manager).create()
 
-    let payIds
     const pProviderService = container.resolve("paymentProviderService")
 
     const payProviders =
       silentResolution(container, "paymentProviders", logger) || []
 
-    payIds = payProviders.map((p) => p.getIdentifier())
+    const payIds = payProviders.map((p) => p.getIdentifier())
+
     await pProviderService.registerInstalledProviders(payIds)
 
-    let notiIds
     const nProviderService = container.resolve("notificationService")
 
     const notiProviders =
       silentResolution(container, "notificationProviders", logger) || []
 
-    notiIds = notiProviders.map((p) => p.getIdentifier())
+    const notiIds = notiProviders.map((p) => p.getIdentifier())
     await nProviderService.registerInstalledProviders(notiIds)
 
-    let fulfilIds
     const fProviderService = container.resolve("fulfillmentProviderService")
 
     const fulfilProviders =
       silentResolution(container, "fulfillmentProviders", logger) || []
 
-    fulfilIds = fulfilProviders.map((p) => p.getIdentifier())
+    const fulfilIds = fulfilProviders.map((p) => p.getIdentifier())
     await fProviderService.registerInstalledProviders(fulfilIds)
 
-    let taxIds
     const tProviderService = container.resolve("taxProviderService")
 
     const taxProviders =
       silentResolution(container, "taxProviders", logger) || []
 
-    taxIds = taxProviders.map((p) => p.getIdentifier())
+    const taxIds = taxProviders.map((p) => p.getIdentifier())
     await tProviderService.registerInstalledProviders(taxIds)
 
     await profileService.withTransaction(manager).createDefault()

packages/medusa/src/services/fulfillment-provider.js

@@ -12,7 +12,8 @@ class FulfillmentProviderService {
   async registerInstalledProviders(providers) {
     const { manager, fulfillmentProviderRepository } = this.container_
     const model = manager.getCustomRepository(fulfillmentProviderRepository)
-    model.update({}, { is_installed: false })
+    await model.update({}, { is_installed: false })
+
     for (const p of providers) {
       const n = model.create({ id: p, is_installed: true })
       await model.save(n)
@@ -23,7 +24,7 @@ class FulfillmentProviderService {
     const { manager, fulfillmentProviderRepository } = this.container_
     const fpRepo = manager.getCustomRepository(fulfillmentProviderRepository)
 
-    return fpRepo.find({})
+    return await fpRepo.find({})
   }
 
   async listFulfillmentOptions(providers) {

packages/medusa/src/services/payment-provider.js

@@ -34,8 +34,10 @@ class PaymentProviderService extends BaseService {
 
   async registerInstalledProviders(providers) {
     const { manager, paymentProviderRepository } = this.container_
+
     const model = manager.getCustomRepository(paymentProviderRepository)
-    model.update({}, { is_installed: false })
+    await model.update({}, { is_installed: false })
+
     for (const p of providers) {
       const n = model.create({ id: p, is_installed: true })
       await model.save(n)
@@ -46,7 +48,7 @@ class PaymentProviderService extends BaseService {
     const { manager, paymentProviderRepository } = this.container_
     const ppRepo = manager.getCustomRepository(paymentProviderRepository)
 
-    return ppRepo.find({})
+    return await ppRepo.find({})
   }
 
   async retrievePayment(id, relations = []) {

packages/medusa/src/services/tax-provider.ts

@@ -431,7 +431,8 @@ class TaxProviderService extends BaseService {
 
   async registerInstalledProviders(providers: string[]): Promise<void> {
     const model = this.manager_.getCustomRepository(this.taxProviderRepo_)
-    model.update({}, { is_installed: false })
+    await model.update({}, { is_installed: false })
+
     for (const p of providers) {
       const n = model.create({ id: p, is_installed: true })
       await model.save(n)