fix(medusa): throw proper error when product doesn't exist w/ key header (#5745)

**What**
- ensure that an error is raised properly if the requested product doesn't exist and a publishable-key header is set

**Why**
- previously endpoints would hang if the product didn't exist and requests would time out


closes #5724

packages/medusa/src/api/middlewares/publishable-api-key/validate-product-sales-channel-association.ts

@@ -26,13 +26,18 @@ async function validateProductSalesChannelAssociation(
     const { sales_channel_ids: salesChannelIds } =
       await publishableKeyService.getResourceScopes(pubKey)
 
-    if (
-      salesChannelIds.length &&
-      !(await productService.isProductInSalesChannels(
+    let isProductInSalesChannel = false
+
+    try {
+      isProductInSalesChannel = await productService.isProductInSalesChannels(
         req.params.id,
         salesChannelIds
-      ))
-    ) {
+      )
+    } catch (error) {
+      next(error)
+    }
+
+    if (salesChannelIds.length && !isProductInSalesChannel) {
       req.errors = req.errors ?? []
       req.errors.push(
         `Product with id: ${req.params.id} is not associated with sales channels defined by the Publishable API Key passed in the header of the request.`

packages/medusa/src/api/middlewares/publishable-api-key/validate-variant-sales-channel-association.ts

@@ -28,13 +28,19 @@ async function validateProductVariantSalesChannelAssociation(
     const { sales_channel_ids: salesChannelIds } =
       await publishableKeyService.getResourceScopes(pubKey)
 
-    if (
-      salesChannelIds.length &&
-      !(await productVariantService.isVariantInSalesChannels(
-        req.params.id,
-        salesChannelIds
-      ))
-    ) {
+    let isVariantInSalesChannel = false
+
+    try {
+      isVariantInSalesChannel =
+        await productVariantService.isVariantInSalesChannels(
+          req.params.id,
+          salesChannelIds
+        )
+    } catch (error) {
+      next(error)
+    }
+
+    if (salesChannelIds.length && !isVariantInSalesChannel) {
       req.errors = req.errors ?? []
       req.errors.push(
         `Variant with id: ${req.params.id} is not associated with sales channels defined by the Publishable API Key passed in the header of the request.`