From e760dbc9534081aab5bdd1b7d99b4561844e6a8d Mon Sep 17 00:00:00 2001 From: "Carlos R. L. Rodrigues" <37986729+carlos-r-l-rodrigues@users.noreply.github.com> Date: Wed, 22 May 2024 10:07:30 -0300 Subject: [PATCH] fix(link-modules): fix warn on readonly links (#7403) --- .../modules/link-modules/src/utils/generate-schema.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/modules/link-modules/src/utils/generate-schema.ts b/packages/modules/link-modules/src/utils/generate-schema.ts index bb8dd23aa1..9c09ba6886 100644 --- a/packages/modules/link-modules/src/utils/generate-schema.ts +++ b/packages/modules/link-modules/src/utils/generate-schema.ts @@ -12,7 +12,8 @@ export function generateGraphQLSchema( let fieldNames!: string[] let entityName!: string - if (!joinerConfig.isReadOnlyLink) { + const isReadOnlyLink = joinerConfig.isReadOnlyLink + if (!isReadOnlyLink) { fieldNames = primary.foreignKey.split(",").concat(foreign.foreignKey) entityName = toPascalCase( @@ -31,7 +32,11 @@ export function generateGraphQLSchema( for (const extend of joinerConfig.extends ?? []) { const extendedModule = MedusaModule.getModuleInstance(extend.serviceName) - if (!extendedModule && !extend.relationship.isInternalService) { + if ( + !isReadOnlyLink && + !extendedModule && + !extend.relationship.isInternalService + ) { throw new Error( `Module ${extend.serviceName} not found. Please verify that the module is configured and installed, also the module must be loaded before the link modules.` ) @@ -69,7 +74,7 @@ export function generateGraphQLSchema( ` } - if (joinerConfig.isReadOnlyLink) { + if (isReadOnlyLink) { return typeDef }