asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: default isQueryable module (#8192)

Browse Source 
* chore: default isQueryable module

* fix defaults

* fix
This commit is contained in:
Adrien de Peretti
2024-07-19 16:14:42 +02:00
committed by GitHub
parent 4ef268d829
commit ecc97076b5
3 changed files with 38 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/modules-sdk/src/definitions.ts
View File

@@ -42,6 +42,7 @@ export const ModulesDefinition: {
defaultPackage: MODULE_PACKAGE_NAMES[Modules.EVENT_BUS],
label: upperCaseFirst(ModuleRegistrationName.EVENT_BUS),
isRequired: true,
isQueryable: false,
dependencies: ["logger"],
defaultModuleDeclaration: {
scope: MODULE_SCOPE.INTERNAL,
@@ -80,6 +81,7 @@ export const ModulesDefinition: {
defaultPackage: MODULE_PACKAGE_NAMES[Modules.CACHE],
label: upperCaseFirst(ModuleRegistrationName.CACHE),
isRequired: true,
isQueryable: false,
defaultModuleDeclaration: {
scope: MODULE_SCOPE.INTERNAL,
resources: MODULE_RESOURCE_TYPE.SHARED,

32
packages/core/modules-sdk/src/medusa-module.ts
View File

@@ -387,9 +387,19 @@ class MedusaModule {
services[keyName].__definition = resolution.definition
if (resolution.definition.isQueryable) {
const joinerConfig: ModuleJoinerConfig = await services[
keyName
].__joinerConfig()
let joinerConfig!: ModuleJoinerConfig
try {
joinerConfig = await services[keyName].__joinerConfig?.()
} catch {
// noop
}
if (!joinerConfig) {
throw new Error(
`Your module is missing a joiner config: ${keyName}. If this module is not queryable, please set { definition: { isQueryable: false } } in your module configuration.`
)
}
if (!joinerConfig.primaryKeys) {
logger_.warn(
@@ -513,9 +523,19 @@ class MedusaModule {
services[keyName].__definition = resolution.definition
if (resolution.definition.isQueryable) {
const joinerConfig: ModuleJoinerConfig = await services[
keyName
].__joinerConfig()
let joinerConfig!: ModuleJoinerConfig
try {
joinerConfig = await services[keyName].__joinerConfig?.()
} catch {
// noop
}
if (!joinerConfig) {
throw new Error(
`Your module is missing a joiner config: ${keyName}. If this module is not queryable, please set { definition: { isQueryable: false } } in your module configuration.`
)
}
services[keyName].__joinerConfig = joinerConfig
MedusaModule.setJoinerConfig(keyName, joinerConfig)