From ed104d5aacc67fd82ea335fc18d4f65206285543 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Frane=20Poli=C4=87?=
 <16856471+fPolic@users.noreply.github.com>
Date: Fri, 21 Jun 2024 14:43:07 +0200
Subject: [PATCH] fix(dashboard): manage locations for item location levels
 (#7794)

* fix: manage locations for item location levels

* fix: toast
---
 .../dashboard/src/i18n/translations/en.json     |  3 +++
 .../components/location-item.tsx                | 17 +++++++++++++----
 .../components/manage-locations-form.tsx        | 17 ++++++++---------
 3 files changed, 24 insertions(+), 13 deletions(-)

diff --git a/packages/admin-next/dashboard/src/i18n/translations/en.json b/packages/admin-next/dashboard/src/i18n/translations/en.json
index b22f0e042b..ee25945326 100644
--- a/packages/admin-next/dashboard/src/i18n/translations/en.json
+++ b/packages/admin-next/dashboard/src/i18n/translations/en.json
@@ -481,6 +481,9 @@
       "successToast": "Reservation was successfully created.",
       "updateSuccessToast": "Reservation was successfully updated.",
       "deleteSuccessToast": "Reservation was successfully deleted."
+    },
+    "toast": {
+      "updateLocations": "Locations updated successfully."
     }
   },
   "giftCards": {
diff --git a/packages/admin-next/dashboard/src/routes/inventory/inventory-detail/components/manage-locations/components/location-item.tsx b/packages/admin-next/dashboard/src/routes/inventory/inventory-detail/components/manage-locations/components/location-item.tsx
index 4c079ae382..eadd4f1089 100644
--- a/packages/admin-next/dashboard/src/routes/inventory/inventory-detail/components/manage-locations/components/location-item.tsx
+++ b/packages/admin-next/dashboard/src/routes/inventory/inventory-detail/components/manage-locations/components/location-item.tsx
@@ -15,13 +15,22 @@ export const LocationItem = ({
 }: LocationItemProps) => {
   return (
     <div
-      className={clx("flex w-full gap-x-2 rounded-lg border px-2 py-2", {
-        "border-ui-border-interactive ": selected,
-      })}
+      className={clx(
+        "flex w-full cursor-pointer gap-x-2 rounded-lg border px-2 py-2",
+        {
+          "border-ui-border-interactive ": selected,
+        }
+      )}
       onClick={() => onSelect(!selected)}
     >
       <div className="h-5 w-5">
-        <Checkbox checked={selected} />
+        <Checkbox
+          onClick={(e) => {
+            e.stopPropagation()
+            onSelect(!selected)
+          }}
+          checked={selected}
+        />
       </div>
       <div className="flex w-full flex-col">
         <Text size="small" leading="compact" weight="plus">
diff --git a/packages/admin-next/dashboard/src/routes/inventory/inventory-detail/components/manage-locations/components/manage-locations-form.tsx b/packages/admin-next/dashboard/src/routes/inventory/inventory-detail/components/manage-locations/components/manage-locations-form.tsx
index ac04f606d8..edb226e652 100644
--- a/packages/admin-next/dashboard/src/routes/inventory/inventory-detail/components/manage-locations/components/manage-locations-form.tsx
+++ b/packages/admin-next/dashboard/src/routes/inventory/inventory-detail/components/manage-locations/components/manage-locations-form.tsx
@@ -1,6 +1,10 @@
 import * as zod from "zod"
 
 import { Button, Text, toast } from "@medusajs/ui"
+import { AdminInventoryItem, AdminStockLocation } from "@medusajs/types"
+import { useTranslation } from "react-i18next"
+import { z } from "zod"
+import { zodResolver } from "@hookform/resolvers/zod"
 import {
   RouteDrawer,
   useRouteModal,
@@ -8,16 +12,11 @@ import {
 import { useBatchUpdateInventoryLevels } from "../../../../../../hooks/api/inventory"
 import { useFieldArray, useForm } from "react-hook-form"
 
-import { InventoryItemRes } from "../../../../../../types/api-responses"
 import { LocationItem } from "./location-item"
-import { StockLocationDTO } from "@medusajs/types"
-import { useTranslation } from "react-i18next"
-import { z } from "zod"
-import { zodResolver } from "@hookform/resolvers/zod"
 
 type EditInventoryItemAttributeFormProps = {
-  item: InventoryItemRes["inventory_item"]
-  locations: StockLocationDTO[]
+  item: AdminInventoryItem
+  locations: AdminStockLocation[]
 }
 
 const EditInventoryItemAttributesSchema = z.object({
@@ -31,7 +30,7 @@ const EditInventoryItemAttributesSchema = z.object({
 })
 
 const getDefaultValues = (
-  allLocations: StockLocationDTO[],
+  allLocations: AdminStockLocation[],
   existingLevels: Set<string>
 ) => {
   return {
@@ -105,7 +104,7 @@ export const ManageLocationsForm = ({
       handleSuccess()
 
       toast.success(t("general.success"), {
-        description: t("inventory.toast.update"),
+        description: t("inventory.toast.updateLocations"),
         dismissLabel: t("actions.close"),
       })
     } catch (e) {