fix: make packages/medusa/src/api/routes/admin/notes pass eslint (#690)

.eslintignore

@@ -23,7 +23,6 @@
 /packages/medusa/src/loaders/subscribers.js
 /packages/medusa/src/api/routes/admin/auth
 /packages/medusa/src/api/routes/admin/collections
-/packages/medusa/src/api/routes/admin/notes
 /packages/medusa/src/api/routes/store/carts
 /packages/medusa/src/api/routes/store/return-reasons
 /packages/medusa/src/api/routes/store/returns

packages/medusa/src/api/routes/admin/notes/create-note.js

@@ -46,18 +46,14 @@ export default async (req, res) => {
     throw new MedusaError(MedusaError.Types.INVALID_DATA, error.details)
   }
 
-  try {
+  const noteService = req.scope.resolve("noteService")
-    const noteService = req.scope.resolve("noteService")
 
-    const result = await noteService.create({
+  const result = await noteService.create({
-      resource_id: value.resource_id,
+    resource_id: value.resource_id,
-      resource_type: value.resource_type,
+    resource_type: value.resource_type,
-      value: value.value,
+    value: value.value,
-      author_id: userId,
+    author_id: userId,
-    })
+  })
 
-    res.status(200).json({ note: result })
+  res.status(200).json({ note: result })
-  } catch (err) {
-    throw err
-  }
 }

packages/medusa/src/api/routes/admin/notes/delete-note.js

@@ -24,12 +24,8 @@
 export default async (req, res) => {
   const { id } = req.params
 
-  try {
+  const noteService = req.scope.resolve("noteService")
-    const noteService = req.scope.resolve("noteService")
+  await noteService.delete(id)
-    await noteService.delete(id)
 
-    res.status(200).json({ id, deleted: true })
+  res.status(200).json({ id, deleted: true })
-  } catch (err) {
-    throw err
-  }
 }

packages/medusa/src/api/routes/admin/notes/get-note.js

@@ -20,12 +20,8 @@
 export default async (req, res) => {
   const { id } = req.params
 
-  try {
+  const noteService = req.scope.resolve("noteService")
-    const noteService = req.scope.resolve("noteService")
+  const note = await noteService.retrieve(id, { relations: ["author"] })
-    const note = await noteService.retrieve(id, { relations: ["author"] })
 
-    res.status(200).json({ note })
+  res.status(200).json({ note })
-  } catch (err) {
-    throw err
-  }
 }

packages/medusa/src/api/routes/admin/notes/index.js

@@ -3,7 +3,7 @@ import middlewares from "../../../middlewares"
 
 const route = Router()
 
-export default app => {
+export default (app) => {
   app.use("/notes", route)
 
   route.get("/:id", middlewares.wrap(require("./get-note").default))

packages/medusa/src/api/routes/admin/notes/list-notes.js

@@ -18,25 +18,21 @@
  *                 $ref: "#/components/schemas/note"
  */
 export default async (req, res) => {
-  try {
+  const limit = parseInt(req.query.limit) || 50
-    const limit = parseInt(req.query.limit) || 50
+  const offset = parseInt(req.query.offset) || 0
-    const offset = parseInt(req.query.offset) || 0
 
-    const selector = {}
+  const selector = {}
 
-    if ("resource_id" in req.query) {
+  if ("resource_id" in req.query) {
-      selector.resource_id = req.query.resource_id
+    selector.resource_id = req.query.resource_id
-    }
-
-    const noteService = req.scope.resolve("noteService")
-    const notes = await noteService.list(selector, {
-      take: limit,
-      skip: offset,
-      relations: ["author"],
-    })
-
-    res.status(200).json({ notes })
-  } catch (err) {
-    throw err
   }
+
+  const noteService = req.scope.resolve("noteService")
+  const notes = await noteService.list(selector, {
+    take: limit,
+    skip: offset,
+    relations: ["author"],
+  })
+
+  res.status(200).json({ notes })
 }

packages/medusa/src/api/routes/admin/notes/update-note.js

@@ -40,12 +40,8 @@ export default async (req, res) => {
     throw new MedusaError(MedusaError.Types.INVALID_DATA, error.details)
   }
 
-  try {
+  const noteService = req.scope.resolve("noteService")
-    const noteService = req.scope.resolve("noteService")
+  const result = await noteService.update(id, value.value)
-    const result = await noteService.update(id, value.value)
 
-    res.status(200).json({ note: result })
+  res.status(200).json({ note: result })
-  } catch (err) {
-    throw err
-  }
 }