From f0ecef6b9ae878e83be0efaf13d6f3fef5d48e3a Mon Sep 17 00:00:00 2001
From: Oliver Windall Juhl <59018053+olivermrbl@users.noreply.github.com>
Date: Thu, 19 May 2022 18:56:58 +0200
Subject: [PATCH] fix(medisa): Deleting price list should use `remove` (#1540)

---
 integration-tests/api/__tests__/admin/price-list.js | 13 +++++++++++++
 packages/medusa/src/services/price-list.ts          |  5 +++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/integration-tests/api/__tests__/admin/price-list.js b/integration-tests/api/__tests__/admin/price-list.js
index 07027628a1..6dd4a8face 100644
--- a/integration-tests/api/__tests__/admin/price-list.js
+++ b/integration-tests/api/__tests__/admin/price-list.js
@@ -945,6 +945,19 @@ describe("/admin/price-lists", () => {
         object: "price-list",
         deleted: true,
       })
+
+      try {
+        await api.get("/admin/price-lists/pl_no_customer_groups", {
+          headers: {
+            Authorization: "Bearer test_token",
+          },
+        })
+      } catch (error) {
+        expect(error.response.status).toBe(404)
+        expect(error.response.data.message).toEqual(
+          "Price list with id: pl_no_customer_groups was not found"
+        )
+      }
     })
   })
 
diff --git a/packages/medusa/src/services/price-list.ts b/packages/medusa/src/services/price-list.ts
index c0eb750f7d..35db14fe41 100644
--- a/packages/medusa/src/services/price-list.ts
+++ b/packages/medusa/src/services/price-list.ts
@@ -16,8 +16,8 @@ import {
   UpdatePriceListInput,
 } from "../types/price-list"
 import { formatException } from "../utils/exception-formatter"
-import RegionService from "./region"
 import ProductService from "./product"
+import RegionService from "./region"
 
 type PriceListConstructorProps = {
   manager: EntityManager
@@ -232,11 +232,12 @@ class PriceListService extends BaseService {
       const priceListRepo = manager.getCustomRepository(this.priceListRepo_)
 
       const priceList = await priceListRepo.findOne({ where: { id: id } })
+
       if (!priceList) {
         return Promise.resolve()
       }
 
-      await priceListRepo.delete(priceList)
+      await priceListRepo.remove(priceList)
 
       return Promise.resolve()
     })