From f115855282f28d27120726a5fd380cc2c34ef23d Mon Sep 17 00:00:00 2001 From: Adrien de Peretti Date: Tue, 1 Feb 2022 17:25:16 +0100 Subject: [PATCH] Fix(request) retries is broken (#1005) At the moment, when the method `shouldRetryCondition` is called, the condition are using OR which does not take in count 0 which is also considered as false a simple fix is the usage of nullish coalescing --- packages/medusa-js/src/request.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/medusa-js/src/request.ts b/packages/medusa-js/src/request.ts index a7a5502e35..302ef247ab 100644 --- a/packages/medusa-js/src/request.ts +++ b/packages/medusa-js/src/request.ts @@ -159,8 +159,8 @@ class Client { if (cfg) { return this.shouldRetryCondition( err, - cfg.currentRetryAttempt || 1, - cfg.retry || 3 + cfg.currentRetryAttempt ?? 1, + cfg.retry ?? 3 ) } else { return false