From f4c2cd112ed54757ed35a55297b46b36152829cb Mon Sep 17 00:00:00 2001 From: Harminder Virk Date: Mon, 3 Feb 2025 18:46:03 +0530 Subject: [PATCH] fix: issues with peer dependencies (#11272) --- .changeset/selfish-waves-taste.md | 7 +++++++ packages/admin/admin-bundler/package.json | 3 ++- packages/admin/admin-sdk/package.json | 7 ++----- packages/medusa/package.json | 4 ++++ yarn.lock | 7 ++++--- 5 files changed, 19 insertions(+), 9 deletions(-) create mode 100644 .changeset/selfish-waves-taste.md diff --git a/.changeset/selfish-waves-taste.md b/.changeset/selfish-waves-taste.md new file mode 100644 index 0000000000..05e801970f --- /dev/null +++ b/.changeset/selfish-waves-taste.md @@ -0,0 +1,7 @@ +--- +"@medusajs/medusa": patch +"@medusajs/admin-bundler": patch +"@medusajs/admin-sdk": patch +--- + +fix: issues with peer dependencies diff --git a/packages/admin/admin-bundler/package.json b/packages/admin/admin-bundler/package.json index 3ef694d84b..4c93e30cd5 100644 --- a/packages/admin/admin-bundler/package.json +++ b/packages/admin/admin-bundler/package.json @@ -33,13 +33,14 @@ "@vitejs/plugin-react": "^4.2.1", "autoprefixer": "^10.4.16", "compression": "^1.7.4", + "express": "^4.21.0", + "get-port": "^5.1.1", "glob": "^10.3.10", "postcss": "^8.4.32", "tailwindcss": "^3.3.6", "vite": "^5.2.11" }, "peerDependencies": { - "express": "^4.21.0", "react-dom": "^18.0.0" }, "packageManager": "yarn@3.2.1" diff --git a/packages/admin/admin-sdk/package.json b/packages/admin/admin-sdk/package.json index d02c166b4c..40e311766e 100644 --- a/packages/admin/admin-sdk/package.json +++ b/packages/admin/admin-sdk/package.json @@ -21,13 +21,10 @@ "devDependencies": { "@types/react": "^18.3.2", "tsup": "^8.0.1", - "typescript": "^5.3.3", - "zod": "^3.22" + "typescript": "^5.3.3" }, "dependencies": { - "@medusajs/admin-shared": "~2.4.0" - }, - "peerDependencies": { + "@medusajs/admin-shared": "~2.4.0", "zod": "^3.22" }, "packageManager": "yarn@3.2.1" diff --git a/packages/medusa/package.json b/packages/medusa/package.json index d1f6610aaa..08a7873aba 100644 --- a/packages/medusa/package.json +++ b/packages/medusa/package.json @@ -133,9 +133,13 @@ "@mikro-orm/migrations": "6.4.3", "@mikro-orm/postgresql": "6.4.3", "awilix": "^8.0.1", + "react-dom": "^18.0.0", "yalc": "1.0.0-pre.53" }, "peerDependenciesMeta": { + "react-dom": { + "optional": true + }, "yalc": { "optional": true } diff --git a/yarn.lock b/yarn.lock index 2af8c2dd03..63dd30c3ab 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5260,6 +5260,7 @@ __metadata: compression: ^1.7.4 copyfiles: ^2.4.1 express: ^4.21.0 + get-port: ^5.1.1 glob: ^10.3.10 postcss: ^8.4.32 tailwindcss: ^3.3.6 @@ -5267,7 +5268,6 @@ __metadata: typescript: ^5.3.3 vite: ^5.2.11 peerDependencies: - express: ^4.21.0 react-dom: ^18.0.0 languageName: unknown linkType: soft @@ -5281,8 +5281,6 @@ __metadata: tsup: ^8.0.1 typescript: ^5.3.3 zod: ^3.22 - peerDependencies: - zod: ^3.22 languageName: unknown linkType: soft @@ -6153,8 +6151,11 @@ __metadata: "@mikro-orm/migrations": 6.4.3 "@mikro-orm/postgresql": 6.4.3 awilix: ^8.0.1 + react-dom: ^18.0.0 yalc: 1.0.0-pre.53 peerDependenciesMeta: + react-dom: + optional: true yalc: optional: true languageName: unknown