fix(promotion): don't evaluate rule condition if conditions to evaluate is empty (#10795)

2025-01-06 09:31:58 +01:00
parent 95b61bf2da
commit f7ffa3540f
3 changed files with 43 additions and 0 deletions
--- a/packages/modules/promotion/src/utils/validations/promotion-rule.ts
+++ b/packages/modules/promotion/src/utils/validations/promotion-rule.ts
@@ -115,6 +115,10 @@ export function evaluateRuleValueCondition(
    ruleValuesToCheck = [ruleValuesToCheck]
  }

+  if (!ruleValuesToCheck.length) {
+    return false
+  }
+
  return ruleValuesToCheck.every((ruleValueToCheck: string) => {
    if (operator === "in" || operator === "eq") {
      return ruleValues.some((ruleValue) => ruleValue === ruleValueToCheck)