chore(product): remove decorator where it is not necessary and cleanup (#4731)

* chore(product): remove decorator where it is not necessary and cleanup

* Create twenty-gorillas-exist.md
This commit is contained in:
Adrien de Peretti
2023-08-10 09:57:32 +02:00
committed by GitHub
parent ac866ebb51
commit f8d3d5f91a
19 changed files with 118 additions and 221 deletions
+10 -16
View File
@@ -1,10 +1,5 @@
import { ProductOption } from "@models"
import {
Context,
DAL,
FindConfig,
ProductTypes,
} from "@medusajs/types"
import { Context, DAL, FindConfig, ProductTypes } from "@medusajs/types"
import { ProductOptionRepository } from "@repositories"
import {
InjectTransactionManager,
@@ -36,10 +31,7 @@ export default class ProductOptionService<
config: FindConfig<ProductTypes.ProductOptionDTO> = {},
@MedusaContext() sharedContext?: Context
): Promise<TEntity> {
return (await retrieveEntity<
ProductOption,
ProductTypes.ProductOptionDTO
>({
return (await retrieveEntity<ProductOption, ProductTypes.ProductOptionDTO>({
id: productOptionId,
entityName: ProductOption.name,
repository: this.productOptionRepository_,
@@ -74,9 +66,12 @@ export default class ProductOptionService<
private buildQueryForList(
filters: ProductTypes.FilterableProductOptionProps = {},
config: FindConfig<ProductTypes.ProductOptionDTO> = {},
config: FindConfig<ProductTypes.ProductOptionDTO> = {}
) {
const queryOptions = ModulesSdkUtils.buildQuery<ProductOption>(filters, config)
const queryOptions = ModulesSdkUtils.buildQuery<ProductOption>(
filters,
config
)
if (filters.title) {
queryOptions.where["title"] = { $ilike: filters.title }
@@ -102,10 +97,9 @@ export default class ProductOptionService<
data: ProductTypes.UpdateProductOptionDTO[],
@MedusaContext() sharedContext: Context = {}
): Promise<TEntity[]> {
return (await (this.productOptionRepository_ as ProductOptionRepository).update(
data,
sharedContext
)) as TEntity[]
return (await (
this.productOptionRepository_ as ProductOptionRepository
).update(data, sharedContext)) as TEntity[]
}
@InjectTransactionManager(doNotForceTransaction, "productOptionRepository_")
+2 -5
View File
@@ -38,10 +38,7 @@ export default class ProductTagService<
config: FindConfig<ProductTypes.ProductTagDTO> = {},
@MedusaContext() sharedContext: Context = {}
): Promise<TEntity> {
return (await retrieveEntity<
ProductTag,
ProductTypes.ProductTagDTO
>({
return (await retrieveEntity<ProductTag, ProductTypes.ProductTagDTO>({
id: productTagId,
entityName: ProductTag.name,
repository: this.productTagRepository_,
@@ -76,7 +73,7 @@ export default class ProductTagService<
private buildQueryForList(
filters: ProductTypes.FilterableProductTagProps = {},
config: FindConfig<ProductTypes.ProductTagDTO> = {},
config: FindConfig<ProductTypes.ProductTagDTO> = {}
) {
const queryOptions = ModulesSdkUtils.buildQuery<ProductTag>(filters, config)
@@ -6,7 +6,7 @@ import {
UpdateProductTypeDTO,
DAL,
FindConfig,
ProductTypes
ProductTypes,
} from "@medusajs/types"
import { ProductTypeRepository } from "@repositories"
import {
@@ -38,10 +38,7 @@ export default class ProductTypeService<
config: FindConfig<ProductTypes.ProductTypeDTO> = {},
@MedusaContext() sharedContext: Context = {}
): Promise<TEntity> {
return (await retrieveEntity<
ProductType,
ProductTypes.ProductTypeDTO
>({
return (await retrieveEntity<ProductType, ProductTypes.ProductTypeDTO>({
id: productTypeId,
entityName: ProductType.name,
repository: this.productTypeRepository_,
@@ -76,9 +73,12 @@ export default class ProductTypeService<
private buildQueryForList(
filters: ProductTypes.FilterableProductTypeProps = {},
config: FindConfig<ProductTypes.ProductTypeDTO> = {},
config: FindConfig<ProductTypes.ProductTypeDTO> = {}
) {
const queryOptions = ModulesSdkUtils.buildQuery<ProductType>(filters, config)
const queryOptions = ModulesSdkUtils.buildQuery<ProductType>(
filters,
config
)
if (filters.value) {
queryOptions.where["value"] = { $ilike: filters.value }
@@ -138,9 +138,11 @@ export default class ProductVariantService<
const variantsData = [...data]
variantsData.forEach((variant) => Object.assign(variant, { product }))
return await (this.productVariantRepository_ as ProductVariantRepository).update(variantsData, {
return (await (
this.productVariantRepository_ as ProductVariantRepository
).update(variantsData, {
transactionManager: sharedContext.transactionManager,
}) as TEntity[]
})) as TEntity[]
}
@InjectTransactionManager(doNotForceTransaction, "productVariantRepository_")