asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(orchestrator, workflows-sdk): skip async step (#9482)

Browse Source
This commit is contained in:
Carlos R. L. Rodrigues
2024-10-07 07:35:30 -03:00
committed by GitHub
parent ad3524ffbe
commit f9e8403d29
1 changed files with 23 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
packages/core/orchestration/src/transaction/transaction-orchestrator.ts
View File

@@ -873,36 +873,32 @@ export class TransactionOrchestrator extends EventEmitter {
promise = stepHandler()
}
// TODO discussion why do we not await here, adding an await I wouldnt expect the test to fail but it does, maybe we should split the test to also test after everything is executed?
// cc test from engine redis
promise
.then(async (response: any) => {
if (
!step.definition.backgroundExecution ||
step.definition.nested
) {
const eventName = DistributedTransactionEvent.STEP_AWAITING
transaction.emit(eventName, { step, transaction })
return
}
if (this.hasExpired({ transaction, step }, Date.now())) {
await this.checkStepTimeout(transaction, step)
await this.checkTransactionTimeout(
transaction,
nextSteps.next.includes(step) ? nextSteps.next : [step]
)
}
let setResponse = true
const output = response?.__type ? response.output : response
if (SkipStepResponse.isSkipStepResponse(output)) {
await TransactionOrchestrator.skipStep(transaction, step)
setResponse = false
}
} else {
if (
!step.definition.backgroundExecution ||
step.definition.nested
) {
const eventName =
DistributedTransactionEvent.STEP_AWAITING
transaction.emit(eventName, { step, transaction })
return
}
if (this.hasExpired({ transaction, step }, Date.now())) {
await this.checkStepTimeout(transaction, step)
await this.checkTransactionTimeout(
transaction,
nextSteps.next.includes(step) ? nextSteps.next : [step]
)
}
if (setResponse) {
await TransactionOrchestrator.setStepSuccess(
transaction,
step,
@@ -1148,7 +1144,9 @@ export class TransactionOrchestrator extends EventEmitter {
queue.push({ obj: obj[key], level: [...level] })
} else if (key === "action") {
if (actionNames.has(obj.action)) {
throw new Error(`Step ${obj.action} is already defined in workflow.`)
throw new Error(
`Step ${obj.action} is already defined in workflow.`
)
}
actionNames.add(obj.action)