* add feature flag for tax inclusive pricing * update db model for TIP * add migration * set featureflag column decorators * remove unused prop * update tests to reflect feature_flags as any array * fix types * reference key from featureFlag file * use feature flag key in models * fix copy paste mistake * unify spelling * Create gorgeous-experts-guess.md * feat(medusa): create/update endpoints of currency/region/price-lists/shipping-options should allow to pass includes_tax * test(integration): continue to add some integration test * test(integration): continue to add some integration test * test(unit): Fix region service tests * fix(medusa): API unit tests flags management * feat(medusa): Minor cleanup * style(medusa): Fix typo * fix(medusa): rebase * feat(medusa): Replace old tag with the new one * feat(medusa): revert flag * feat(medusa): Cleanup * feat(medusa): feedback * feat(medusa): Rename currency retrieve method * test(medudsa): fix unit tests * chore(medusa): fix oas * feat(medusa): ShippingMethod should include tax setting from parent option (#2021) * feat(medusa): Shipping method should includes tax from parent options * feat(medusa): Condition the includes tax flag to the availability of the feature and add some other tests * test(integration): Move cart/order ff test in separate files * fix: snapshots folder * fix(integration): snapshots * Create calm-baboons-sit.md * test(integration): file naming Co-authored-by: Carlos R. L. Rodrigues <rodrigolr@gmail.com> * Feat/tax inclusive pricing extend price selection strategy (#2087) * initial changes to price selection strategy including unit tests * typing for tax calculation * update types and remove region and currency from prices results * fix casing * include tax calculation in priceselectionstrategy * integration tests for tax inclusive pricing price calculations * fix build * include tax inclusive considerations when calculating tax fields for variants * include only "includes_tax" fields from currency and region joins * test to see errors in pipelines * conditionally join featureflagged fields * add "includes_tax" to price list factory * add tests for tax inclusive price list prices and currency prices * fix unit tests * refactor pricing array checks to expect arraycontaining * undo error handler * Feat/tax inclusive pricing flag on generated lineitems (#2108) * include tax inclusive pricing flag on generated lineitems * initial addition of tax inclusivity for lineitem service * add generate test to ensure that includes_tax is set when returned from price selection strategy * add integration test for generating lineitem including tax * add test for negative tax inclusion * add tests for mixed pricing * add negative test for setting tax exclusivity * restructure the setting of includes_tax on lineitems * fix: update cwd to be correct in cart test * feat(medusa): Line item totals calculations (#2123) * feat(medusa): Update totals and tax calculation way to calculate the totals * feat(medusa): remove region feetching from decorate total * feat(medusa): cleanup * test(medusa): fix tax calculation tests * comment * test(integration): cleanup * test(integration): cleanup * fix(medusa): return service missing await * feat(medusa): cleanup * feat(medusa): cleanup * test(integration): fix data * feat(medusa): improve tax calculation readability * test(medusa): improve tax calculation structure case Co-authored-by: Sebastian Rindom <skrindom@gmail.com> * Feat(medusa): tax inclusive pricing in shipping method tax (#2125) * initial implementation and test * include tax inclusive calculations for getting shipping options * remove inaccurate comment * remove console log * refactor how prices and taxes are set for shipping methods * fix integration tests * remove verbose flag * fix integration tests * remove console log * format util * use util in price service and tax strategy * fix faulty integration test * undo tax calculation strategy changes in favor or Carlos' pr * undo changes to tax calculation strategy tests * round tax amount * feat(medusa): cleanup calculate tax amount utils and its usage (#2136) * feat(medusa): Refund line totals calculation (#2139) Rely on the update of the following pr https://github.com/medusajs/medusa/pull/2136 **WIP Missing integration tests** **What** Update the totals calculation on the refund line to include the notion of tax inclusive **Test** - Update and add new tests around the refund Fixes CORE-482 * feat(medusa): Tax inclusive discounts calculations (#2137) **What** - Calculate line adjustments correctly taking into account the tax inclusivity - fix totals getLineItemTotals by adjusting the sub total with the original tax amount instead of the tax amount when the unit price includes the taxes **Tests** - The tests create a cart with a percentage discount of 15%, the cart includes 2 items mixing the tax inclusive and validate the items on the result cart as well as the totals on each item. I ve based my calculation validation based on what we have done + some articles around discount apply on price without taxes to validate the output., FIXES CORE-477 * Chore: shipping methods tax inclusive total (#2130) * chore: calculate tax inclusive shipping methods * chore: additional tests and check undefined tax_rate (#2157) * chore: additional tests and check undefined tax_rate * fix: naming + correct price type check * fix: remove price_includes_tax from type * fix: remove price_includes_tax from type Co-authored-by: Philip Korsholm <philip.korsholm@hotmail.com> Co-authored-by: adrien2p <adrien.deperetti@gmail.com> Co-authored-by: Carlos R. L. Rodrigues <rodrigolr@gmail.com> Co-authored-by: Philip Korsholm <88927411+pKorsholm@users.noreply.github.com> Co-authored-by: Sebastian Rindom <skrindom@gmail.com> Co-authored-by: Carlos R. L. Rodrigues <37986729+carlos-r-l-rodrigues@users.noreply.github.com>
585 lines
14 KiB
JavaScript
585 lines
14 KiB
JavaScript
const path = require("path")
|
|
const {
|
|
ShippingProfile,
|
|
} = require("@medusajs/medusa")
|
|
|
|
const setupServer = require("../../../helpers/setup-server")
|
|
const startServerWithEnvironment = require("../../../helpers/start-server-with-environment").default
|
|
const { useApi } = require("../../../helpers/use-api")
|
|
const { initDb, useDb } = require("../../../helpers/use-db")
|
|
const adminSeeder = require("../../helpers/admin-seeder")
|
|
const shippingOptionSeeder = require("../../helpers/shipping-option-seeder")
|
|
const { simpleShippingOptionFactory, simpleRegionFactory } = require("../../factories")
|
|
|
|
const adminReqConfig = {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
}
|
|
|
|
jest.setTimeout(30000)
|
|
|
|
describe("/admin/shipping-options", () => {
|
|
let medusaProcess
|
|
let dbConnection
|
|
|
|
beforeAll(async () => {
|
|
const cwd = path.resolve(path.join(__dirname, "..", ".."))
|
|
dbConnection = await initDb({ cwd })
|
|
medusaProcess = await setupServer({ cwd })
|
|
})
|
|
|
|
afterAll(async () => {
|
|
const db = useDb()
|
|
await db.shutdown()
|
|
medusaProcess.kill()
|
|
})
|
|
|
|
describe("POST /admin/shipping-options/:id", () => {
|
|
beforeEach(async () => {
|
|
await adminSeeder(dbConnection)
|
|
await shippingOptionSeeder(dbConnection)
|
|
})
|
|
|
|
afterEach(async () => {
|
|
const db = useDb()
|
|
await db.teardown()
|
|
})
|
|
|
|
it("updates a shipping option with no existing requirements", async () => {
|
|
const api = useApi()
|
|
|
|
const payload = {
|
|
name: "Test option",
|
|
amount: 100,
|
|
requirements: [
|
|
{
|
|
type: "min_subtotal",
|
|
amount: 1,
|
|
},
|
|
{
|
|
type: "max_subtotal",
|
|
amount: 2,
|
|
},
|
|
],
|
|
}
|
|
|
|
const res = await api.post(`/admin/shipping-options/test-out`, payload, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
|
|
const requirements = res.data.shipping_option.requirements
|
|
|
|
expect(res.status).toEqual(200)
|
|
expect(requirements.length).toEqual(2)
|
|
expect(requirements[0]).toEqual(
|
|
expect.objectContaining({
|
|
type: "min_subtotal",
|
|
shipping_option_id: "test-out",
|
|
amount: 1,
|
|
})
|
|
)
|
|
expect(requirements[1]).toEqual(
|
|
expect.objectContaining({
|
|
type: "max_subtotal",
|
|
shipping_option_id: "test-out",
|
|
amount: 2,
|
|
})
|
|
)
|
|
})
|
|
|
|
it("fails as it is not allowed to set id from client side", async () => {
|
|
const api = useApi()
|
|
|
|
const payload = {
|
|
name: "Test option",
|
|
amount: 100,
|
|
requirements: [
|
|
{
|
|
id: "not_allowed",
|
|
type: "min_subtotal",
|
|
amount: 1,
|
|
},
|
|
{
|
|
id: "really_not_allowed",
|
|
type: "max_subtotal",
|
|
amount: 2,
|
|
},
|
|
],
|
|
}
|
|
|
|
const res = await api
|
|
.post(`/admin/shipping-options/test-out`, payload, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
.catch((err) => {
|
|
return err.response
|
|
})
|
|
|
|
expect(res.status).toEqual(400)
|
|
expect(res.data.message).toEqual("ID does not exist")
|
|
})
|
|
|
|
it("it successfully updates a set of existing requirements", async () => {
|
|
const api = useApi()
|
|
|
|
const payload = {
|
|
requirements: [
|
|
{
|
|
id: "option-req",
|
|
type: "min_subtotal",
|
|
amount: 15,
|
|
},
|
|
{
|
|
id: "option-req-2",
|
|
type: "max_subtotal",
|
|
amount: 20,
|
|
},
|
|
],
|
|
amount: 200,
|
|
}
|
|
|
|
const res = await api
|
|
.post(`/admin/shipping-options/test-option-req`, payload, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
.catch((err) => {
|
|
console.log(err.response.data.message)
|
|
})
|
|
|
|
expect(res.status).toEqual(200)
|
|
})
|
|
|
|
it("it successfully updates a set of existing requirements by updating one and deleting the other", async () => {
|
|
const api = useApi()
|
|
|
|
const payload = {
|
|
requirements: [
|
|
{
|
|
id: "option-req",
|
|
type: "min_subtotal",
|
|
amount: 15,
|
|
},
|
|
],
|
|
}
|
|
|
|
const res = await api
|
|
.post(`/admin/shipping-options/test-option-req`, payload, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
.catch((err) => {
|
|
console.log(err.response.data.message)
|
|
})
|
|
|
|
expect(res.status).toEqual(200)
|
|
})
|
|
|
|
it("successfully updates a set of requirements because max. subtotal >= min. subtotal", async () => {
|
|
const api = useApi()
|
|
|
|
const payload = {
|
|
requirements: [
|
|
{
|
|
id: "option-req",
|
|
type: "min_subtotal",
|
|
amount: 150,
|
|
},
|
|
{
|
|
id: "option-req-2",
|
|
type: "max_subtotal",
|
|
amount: 200,
|
|
},
|
|
],
|
|
}
|
|
|
|
const res = await api
|
|
.post(`/admin/shipping-options/test-option-req`, payload, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
.catch((err) => {
|
|
console.log(err.response.data.message)
|
|
})
|
|
|
|
expect(res.status).toEqual(200)
|
|
expect(res.data.shipping_option.requirements[0].amount).toEqual(150)
|
|
expect(res.data.shipping_option.requirements[1].amount).toEqual(200)
|
|
})
|
|
|
|
it("fails to updates a set of requirements because max. subtotal <= min. subtotal", async () => {
|
|
const api = useApi()
|
|
|
|
const payload = {
|
|
requirements: [
|
|
{
|
|
id: "option-req",
|
|
type: "min_subtotal",
|
|
amount: 1500,
|
|
},
|
|
{
|
|
id: "option-req-2",
|
|
type: "max_subtotal",
|
|
amount: 200,
|
|
},
|
|
],
|
|
}
|
|
|
|
const res = await api
|
|
.post(`/admin/shipping-options/test-option-req`, payload, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
.catch((err) => {
|
|
return err.response
|
|
})
|
|
|
|
expect(res.status).toEqual(400)
|
|
expect(res.data.message).toEqual(
|
|
"Max. subtotal must be greater than Min. subtotal"
|
|
)
|
|
})
|
|
})
|
|
|
|
describe("POST /admin/shipping-options", () => {
|
|
let payload
|
|
|
|
beforeEach(async () => {
|
|
await adminSeeder(dbConnection)
|
|
await shippingOptionSeeder(dbConnection)
|
|
|
|
const api = useApi()
|
|
await api.post(
|
|
`/admin/regions/region`,
|
|
{
|
|
fulfillment_providers: ["test-ful"],
|
|
},
|
|
{
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
}
|
|
)
|
|
|
|
const manager = dbConnection.manager
|
|
const defaultProfile = await manager.findOne(ShippingProfile, {
|
|
type: "default",
|
|
})
|
|
|
|
payload = {
|
|
name: "Test option",
|
|
amount: 100,
|
|
price_type: "flat_rate",
|
|
region_id: "region",
|
|
provider_id: "test-ful",
|
|
data: {},
|
|
profile_id: defaultProfile.id,
|
|
}
|
|
})
|
|
|
|
afterEach(async () => {
|
|
const db = useDb()
|
|
await db.teardown()
|
|
})
|
|
|
|
it("creates a shipping option with requirements", async () => {
|
|
const api = useApi()
|
|
payload.requirements = [
|
|
{
|
|
type: "max_subtotal",
|
|
amount: 2,
|
|
},
|
|
{
|
|
type: "min_subtotal",
|
|
amount: 1,
|
|
},
|
|
]
|
|
|
|
const res = await api.post(`/admin/shipping-options`, payload, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
|
|
expect(res.status).toEqual(200)
|
|
expect(res.data.shipping_option.requirements.length).toEqual(2)
|
|
})
|
|
|
|
it("creates a shipping option with no requirements", async () => {
|
|
const api = useApi()
|
|
const res = await api.post(`/admin/shipping-options`, payload, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
|
|
expect(res.status).toEqual(200)
|
|
expect(res.data.shipping_option.requirements.length).toEqual(0)
|
|
})
|
|
|
|
it("fails on same requirement types", async () => {
|
|
const api = useApi()
|
|
payload.requirements = [
|
|
{
|
|
type: "max_subtotal",
|
|
amount: 2,
|
|
},
|
|
{
|
|
type: "max_subtotal",
|
|
amount: 1,
|
|
},
|
|
]
|
|
|
|
try {
|
|
await api.post(`/admin/shipping-options`, payload, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
} catch (error) {
|
|
expect(error.response.data.message).toEqual(
|
|
"Only one requirement of each type is allowed"
|
|
)
|
|
}
|
|
})
|
|
|
|
it("fails when min_subtotal > max_subtotal", async () => {
|
|
const api = useApi()
|
|
payload.requirements = [
|
|
{
|
|
type: "max_subtotal",
|
|
amount: 2,
|
|
},
|
|
{
|
|
type: "min_subtotal",
|
|
amount: 4,
|
|
},
|
|
]
|
|
|
|
try {
|
|
await api.post(`/admin/shipping-options`, payload, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
} catch (error) {
|
|
expect(error.response.data.message).toEqual(
|
|
"Max. subtotal must be greater than Min. subtotal"
|
|
)
|
|
}
|
|
})
|
|
})
|
|
describe("GET /admin/shipping-options", () => {
|
|
beforeEach(async () => {
|
|
await adminSeeder(dbConnection)
|
|
await shippingOptionSeeder(dbConnection)
|
|
})
|
|
|
|
afterEach(async () => {
|
|
const db = useDb()
|
|
await db.teardown()
|
|
})
|
|
|
|
it("lists shipping options", async () => {
|
|
const api = useApi()
|
|
const res = await api.get(`/admin/shipping-options`, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
|
|
expect(res.status).toEqual(200)
|
|
})
|
|
|
|
it("lists admin only shipping options", async () => {
|
|
const api = useApi()
|
|
const res = await api.get(`/admin/shipping-options?admin_only=true`, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
|
|
expect(res.status).toEqual(200)
|
|
expect(res.data.shipping_options).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({
|
|
id: "test-option-req-admin-only",
|
|
admin_only: true,
|
|
}),
|
|
])
|
|
)
|
|
})
|
|
|
|
it("lists return shipping options", async () => {
|
|
const api = useApi()
|
|
const res = await api.get(`/admin/shipping-options?is_return=true`, {
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
})
|
|
|
|
expect(res.status).toEqual(200)
|
|
expect(res.data.shipping_options).toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({
|
|
id: "test-option-req-return",
|
|
is_return: true,
|
|
}),
|
|
])
|
|
)
|
|
})
|
|
|
|
it("lists shipping options without return and admin options", async () => {
|
|
const api = useApi()
|
|
const res = await api.get(
|
|
`/admin/shipping-options?is_return=false&admin_only=true`,
|
|
{
|
|
headers: {
|
|
Authorization: "Bearer test_token",
|
|
},
|
|
}
|
|
)
|
|
|
|
expect(res.status).toEqual(200)
|
|
expect(res.data.shipping_options).not.toEqual(
|
|
expect.arrayContaining([
|
|
expect.objectContaining({
|
|
id: "test-option-req-return",
|
|
is_return: true,
|
|
}),
|
|
expect.objectContaining({
|
|
id: "test-option-req-admin-only",
|
|
admin_only: true,
|
|
}),
|
|
])
|
|
)
|
|
})
|
|
})
|
|
})
|
|
|
|
describe("[MEDUSA_FF_TAX_INCLUSIVE_PRICING] /admin/shipping-options", () => {
|
|
let medusaProcess
|
|
let dbConnection
|
|
|
|
beforeAll(async () => {
|
|
const cwd = path.resolve(path.join(__dirname, "..", ".."))
|
|
const [process, connection] = await startServerWithEnvironment({
|
|
cwd,
|
|
env: { MEDUSA_FF_TAX_INCLUSIVE_PRICING: true },
|
|
verbose: false,
|
|
})
|
|
dbConnection = connection
|
|
medusaProcess = process
|
|
})
|
|
|
|
afterAll(async () => {
|
|
const db = useDb()
|
|
await db.shutdown()
|
|
|
|
medusaProcess.kill()
|
|
})
|
|
|
|
describe("POST /admin/shipping-options", () => {
|
|
const shippingOptionIncludesTaxId = "shipping-option-1-includes-tax"
|
|
let region
|
|
|
|
beforeEach(async () => {
|
|
try {
|
|
await adminSeeder(dbConnection)
|
|
region = await simpleRegionFactory(dbConnection, {
|
|
id: "region",
|
|
countries: ["fr"],
|
|
})
|
|
await simpleShippingOptionFactory(dbConnection, {
|
|
id: shippingOptionIncludesTaxId,
|
|
region_id: region.id,
|
|
})
|
|
} catch (err) {
|
|
console.log(err)
|
|
throw err
|
|
}
|
|
})
|
|
|
|
afterEach(async () => {
|
|
const db = useDb()
|
|
await db.teardown()
|
|
})
|
|
|
|
it("should creates a shipping option that includes tax", async () => {
|
|
const api = useApi()
|
|
|
|
const defaultProfile = await dbConnection.manager.findOne(ShippingProfile, {
|
|
type: "default",
|
|
})
|
|
|
|
const payload = {
|
|
name: "Test option",
|
|
amount: 100,
|
|
price_type: "flat_rate",
|
|
region_id: region.id,
|
|
provider_id: "test-ful",
|
|
data: {},
|
|
profile_id: defaultProfile.id,
|
|
includes_tax: true,
|
|
}
|
|
|
|
const response = await api
|
|
.post("/admin/shipping-options", payload, adminReqConfig)
|
|
.catch((err) => {
|
|
console.log(err)
|
|
})
|
|
|
|
expect(response.status).toEqual(200)
|
|
expect(response.data.shipping_option).toEqual(
|
|
expect.objectContaining({
|
|
id: expect.any(String),
|
|
includes_tax: true,
|
|
})
|
|
)
|
|
})
|
|
|
|
it("should update a shipping option that include_tax", async () => {
|
|
const api = useApi()
|
|
|
|
let response = await api
|
|
.get(`/admin/shipping-options/${shippingOptionIncludesTaxId}`, adminReqConfig)
|
|
.catch((err) => {
|
|
console.log(err)
|
|
})
|
|
|
|
expect(response.data.shipping_option.includes_tax).toBe(false)
|
|
|
|
const payload = {
|
|
requirements: [
|
|
{
|
|
type: "min_subtotal",
|
|
amount: 1,
|
|
},
|
|
{
|
|
type: "max_subtotal",
|
|
amount: 2,
|
|
},
|
|
],
|
|
includes_tax: true,
|
|
}
|
|
|
|
response = await api
|
|
.post(`/admin/shipping-options/${shippingOptionIncludesTaxId}`, payload, adminReqConfig)
|
|
.catch((err) => {
|
|
console.log(err)
|
|
})
|
|
|
|
expect(response.data.shipping_option.includes_tax).toBe(true)
|
|
})
|
|
})
|
|
})
|