Files
medusa-store/integration-tests/api/__tests__/admin/payment-collection.js
Adrien de Peretti 42d9c7222b feat(medusa): Performance improvements of Carts domain (#2648)
**What**

I have created a new method on the cart service which is `addLineItems`, allowing a user to add one or multiple items in an optimized way. Also updated the `generate` method from the line item service which now also accept a object data or a collection of data which. Various places have been optimized and cache support has been added to the price selection strategy.

The overall optimization allows to reach another 9000% improvement in the response time as a median (Creating a cart with 6 items):

|   | Min (ms)  | Median (ms)  | Max (ms)  | Median Improvement (%)
|---|:-:|---|---|---|
| Before optimisation  | 1200  | 9999 | 12698  |  N/A
| After optimisation | 63  | 252  | 500  | 39x
| After re optimisation | 56 | 82  | 399  | 121x
| After including addressed feedback | 65 | 202  | 495  | 49x

FIXES CORE-722
2022-12-07 14:39:12 +00:00

223 lines
5.3 KiB
JavaScript

const path = require("path")
const startServerWithEnvironment =
require("../../../helpers/start-server-with-environment").default
const { useApi } = require("../../../helpers/use-api")
const { useDb } = require("../../../helpers/use-db")
const adminSeeder = require("../../helpers/admin-seeder")
const {
simplePaymentCollectionFactory,
} = require("../../factories/simple-payment-collection-factory")
jest.setTimeout(30000)
const adminHeaders = {
headers: {
Authorization: "Bearer test_token",
},
}
describe("[MEDUSA_FF_ORDER_EDITING] /admin/payment-collections", () => {
let medusaProcess
let dbConnection
let payCol = null
beforeAll(async () => {
const cwd = path.resolve(path.join(__dirname, "..", ".."))
const [process, connection] = await startServerWithEnvironment({
cwd,
env: { MEDUSA_FF_ORDER_EDITING: true },
})
dbConnection = connection
medusaProcess = process
})
afterAll(async () => {
const db = useDb()
await db.shutdown()
medusaProcess.kill()
})
describe("GET /admin/payment-collections/:id", () => {
beforeEach(async () => {
await adminSeeder(dbConnection)
payCol = await simplePaymentCollectionFactory(dbConnection, {
description: "paycol description",
amount: 10000,
})
})
afterEach(async () => {
const db = useDb()
return await db.teardown()
})
it("gets payment collection", async () => {
const api = useApi()
const response = await api.get(
`/admin/payment-collections/${payCol.id}`,
adminHeaders
)
expect(response.data.payment_collection).toEqual(
expect.objectContaining({
id: payCol.id,
type: "order_edit",
status: "not_paid",
description: "paycol description",
amount: 10000,
})
)
expect(response.status).toEqual(200)
})
})
describe("POST /admin/payment-collections/:id", () => {
beforeEach(async () => {
await adminSeeder(dbConnection)
payCol = await simplePaymentCollectionFactory(dbConnection, {
description: "paycol description",
amount: 10000,
})
})
afterEach(async () => {
const db = useDb()
return await db.teardown()
})
it("updates a payment collection", async () => {
const api = useApi()
const response = await api.post(
`/admin/payment-collections/${payCol.id}`,
{
description: "new description",
metadata: {
a: 1,
b: [1, 2, "3"],
},
},
adminHeaders
)
expect(response.data.payment_collection).toEqual(
expect.objectContaining({
id: payCol.id,
type: "order_edit",
amount: 10000,
description: "new description",
metadata: {
a: 1,
b: [1, 2, "3"],
},
authorized_amount: null,
})
)
expect(response.status).toEqual(200)
})
})
describe("POST /admin/payment-collections/:id/authorize", () => {
beforeEach(async () => {
await adminSeeder(dbConnection)
payCol = await simplePaymentCollectionFactory(dbConnection, {
description: "paycol description",
amount: 10000,
})
})
afterEach(async () => {
const db = useDb()
return await db.teardown()
})
it("marks a payment collection as authorized", async () => {
const api = useApi()
const response = await api.post(
`/admin/payment-collections/${payCol.id}/authorize`,
undefined,
adminHeaders
)
expect(response.data.payment_collection).toEqual(
expect.objectContaining({
id: payCol.id,
type: "order_edit",
status: "authorized",
description: "paycol description",
amount: 10000,
authorized_amount: 10000,
})
)
expect(response.status).toEqual(200)
})
})
describe("DELETE /admin/payment-collections/:id", () => {
beforeEach(async () => {
await adminSeeder(dbConnection)
payCol = await simplePaymentCollectionFactory(dbConnection, {
description: "paycol description",
amount: 10000,
})
})
afterEach(async () => {
const db = useDb()
return await db.teardown()
})
it("delete a payment collection", async () => {
const api = useApi()
const response = await api.delete(
`/admin/payment-collections/${payCol.id}`,
adminHeaders
)
expect(response.data).toEqual({
id: `${payCol.id}`,
deleted: true,
object: "payment_collection",
})
expect(response.status).toEqual(200)
})
it("throws error when deleting an authorized payment collection", async () => {
const api = useApi()
await api.post(
`/admin/payment-collections/${payCol.id}/authorize`,
undefined,
adminHeaders
)
try {
await api.delete(
`/admin/payment-collections/${payCol.id}`,
adminHeaders
)
expect(1).toBe(2) // should be ignored
} catch (res) {
expect(res.response.data.message).toBe(
"Cannot delete payment collection with status authorized"
)
}
})
})
})