Patrick
17c3f34e3d
### What Flip Turborepo cache glob pattern from an allow-list to deny-list pattern. ### Why Packages within medusa's monorepo will output their build to a `dist` directory. This convention does not apply to plugins since the core plugin loader expects the content of plugin packages `src` directory to be outputted at the root of the package. i.e. `packages/foobar-plugin/src/utils/index.ts` -> `packages/foobar-plugin/utils/index.js` Manually maintaining an allow-list of known plugin output directories is not scalable. When a directory exists in a plugin package but is not know to the allow-list, the directory will not be re-built on subsequent builds. Troubleshooting the issue requires intimate knowledge of Turborepo caching strategies. ### How By using a deny-list glob pattern, plugin packages can now declare any not-known directory within their `src` folder without facing any potential omission issues during the build process. We declare `src` and its content as the only directory for turbo cache to ignore. ### Additional scope * Use `turbo.json` file content in cache hashing algorithm in order to break CI cache when changes are made to the Turborepo config. * Upgraded turbo minor verion. * Added missing dependency to medusa package. ### Test * Delete previously built output in packages. Run `yarn build --force` (replace any existing cache) * Expect all src content to be outputted * Run `yarn build` right after * Expect a fast build time since cache will be fresh * Add a new directory with an index.ts file in a plugin package src folder. Run `yarn build` * Expect a fast build time, except for the modified plugin package. * Expect the newly added directory to be outputted. * Delete the newly outputted directory. Run `yarn build` * Expect the outputted directory to reappear. ### References * https://github.com/medusajs/medusa/blob/5093b82f3a28323e99b6b133ae87c76fac01a298/packages/medusa/src/loaders/plugins.ts * https://turbo.build/repo/docs/reference/configuration#outputs * https://turbo.build/repo/docs/reference/configuration#globaldependencies Resolves CORE-891
25 lines
365 B
JSON
25 lines
365 B
JSON
{
|
|
"$schema": "https://turbo.build/schema.json",
|
|
"pipeline": {
|
|
"build": {
|
|
"dependsOn": [
|
|
"^build"
|
|
],
|
|
"outputs": [
|
|
"!node_modules/**",
|
|
"!src/**",
|
|
"/*/**"
|
|
]
|
|
},
|
|
"test": {
|
|
"dependsOn": [
|
|
"build"
|
|
],
|
|
"outputs": []
|
|
}
|
|
},
|
|
"globalDependencies": [
|
|
"turbo.json"
|
|
]
|
|
}
|