From 20440fe07fe866dc4ef29708b6075902f801e0ae Mon Sep 17 00:00:00 2001 From: Vladimir nett00n Budylnikov Date: Thu, 24 Jul 2025 20:49:03 +0400 Subject: [PATCH] reduce nested code --- scripts/AudioManager.gd | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/scripts/AudioManager.gd b/scripts/AudioManager.gd index 286cdd0..a70b826 100644 --- a/scripts/AudioManager.gd +++ b/scripts/AudioManager.gd @@ -7,23 +7,32 @@ var is_music_playing := false func _ready(): add_child(music_player) - var stream: AudioStream = load(MUSIC_PATH) - if not stream: + if not _load_and_configure_stream(): push_error("Failed to load music stream: %s" % MUSIC_PATH) return + _configure_audio_bus() + + if SettingsManager.get_setting("music_volume") > 0: + _start_music() + +func _load_and_configure_stream() -> bool: + var stream: AudioStream = load(MUSIC_PATH) + if not stream: + return false + if stream is AudioStreamWAV: stream.loop_mode = AudioStreamWAV.LOOP_FORWARD elif stream is AudioStreamOggVorbis: stream.loop = true music_player.stream = stream + return true + +func _configure_audio_bus() -> void: music_player.bus = "Music" music_player.volume_db = linear_to_db(SettingsManager.get_setting("music_volume")) - if SettingsManager.get_setting("music_volume") > 0: - _start_music() - func update_music_volume(volume: float) -> void: var volume_db = linear_to_db(volume) music_player.volume_db = volume_db