gdlint fixes
This commit is contained in:
@@ -5,7 +5,7 @@ extends SceneTree
|
||||
## Validates all .tscn files in the project for loading and instantiation errors.
|
||||
## Provides comprehensive scene validation to catch issues before runtime.
|
||||
|
||||
const TestHelper = preload("res://tests/helpers/TestHelper.gd")
|
||||
const TestHelperClass = preload("res://tests/helpers/TestHelper.gd")
|
||||
|
||||
var discovered_scenes: Array[String] = []
|
||||
var validation_results: Dictionary = {}
|
||||
@@ -23,7 +23,7 @@ func _initialize():
|
||||
|
||||
|
||||
func run_tests():
|
||||
TestHelper.print_test_header("Scene Validation")
|
||||
TestHelperClass.print_test_header("Scene Validation")
|
||||
|
||||
# Run test suites
|
||||
test_scene_discovery()
|
||||
@@ -34,11 +34,11 @@ func run_tests():
|
||||
# Print final summary
|
||||
print_validation_summary()
|
||||
|
||||
TestHelper.print_test_footer("Scene Validation")
|
||||
TestHelperClass.print_test_footer("Scene Validation")
|
||||
|
||||
|
||||
func test_scene_discovery():
|
||||
TestHelper.print_step("Scene Discovery")
|
||||
TestHelperClass.print_step("Scene Discovery")
|
||||
|
||||
# Discover scenes in key directories
|
||||
var scene_directories = ["res://scenes/", "res://examples/"]
|
||||
@@ -46,7 +46,7 @@ func test_scene_discovery():
|
||||
for directory in scene_directories:
|
||||
discover_scenes_in_directory(directory)
|
||||
|
||||
TestHelper.assert_true(discovered_scenes.size() > 0, "Found scenes in project")
|
||||
TestHelperClass.assert_true(discovered_scenes.size() > 0, "Found scenes in project")
|
||||
print("Discovered %d scene files" % discovered_scenes.size())
|
||||
|
||||
# List discovered scenes for reference
|
||||
@@ -77,7 +77,7 @@ func discover_scenes_in_directory(directory_path: String):
|
||||
|
||||
|
||||
func test_scene_loading():
|
||||
TestHelper.print_step("Scene Loading Validation")
|
||||
TestHelperClass.print_step("Scene Loading Validation")
|
||||
|
||||
for scene_path in discovered_scenes:
|
||||
validate_scene_loading(scene_path)
|
||||
@@ -89,27 +89,27 @@ func validate_scene_loading(scene_path: String):
|
||||
# Check if resource exists
|
||||
if not ResourceLoader.exists(scene_path):
|
||||
validation_results[scene_path] = "Resource does not exist"
|
||||
TestHelper.assert_false(true, "%s - Resource does not exist" % scene_name)
|
||||
TestHelperClass.assert_false(true, "%s - Resource does not exist" % scene_name)
|
||||
return
|
||||
|
||||
# Attempt to load the scene
|
||||
var packed_scene = load(scene_path)
|
||||
if not packed_scene:
|
||||
validation_results[scene_path] = "Failed to load scene"
|
||||
TestHelper.assert_false(true, "%s - Failed to load scene" % scene_name)
|
||||
TestHelperClass.assert_false(true, "%s - Failed to load scene" % scene_name)
|
||||
return
|
||||
|
||||
if not packed_scene is PackedScene:
|
||||
validation_results[scene_path] = "Resource is not a PackedScene"
|
||||
TestHelper.assert_false(true, "%s - Resource is not a PackedScene" % scene_name)
|
||||
TestHelperClass.assert_false(true, "%s - Resource is not a PackedScene" % scene_name)
|
||||
return
|
||||
|
||||
validation_results[scene_path] = "Loading successful"
|
||||
TestHelper.assert_true(true, "%s - Scene loads successfully" % scene_name)
|
||||
TestHelperClass.assert_true(true, "%s - Scene loads successfully" % scene_name)
|
||||
|
||||
|
||||
func test_scene_instantiation():
|
||||
TestHelper.print_step("Scene Instantiation Testing")
|
||||
TestHelperClass.print_step("Scene Instantiation Testing")
|
||||
|
||||
for scene_path in discovered_scenes:
|
||||
# Only test instantiation for scenes that loaded successfully
|
||||
@@ -127,11 +127,11 @@ func validate_scene_instantiation(scene_path: String):
|
||||
var scene_instance = packed_scene.instantiate()
|
||||
if not scene_instance:
|
||||
validation_results[scene_path] = "Failed to instantiate scene"
|
||||
TestHelper.assert_false(true, "%s - Failed to instantiate scene" % scene_name)
|
||||
TestHelperClass.assert_false(true, "%s - Failed to instantiate scene" % scene_name)
|
||||
return
|
||||
|
||||
# Validate the instance
|
||||
TestHelper.assert_not_null(
|
||||
TestHelperClass.assert_not_null(
|
||||
scene_instance, "%s - Scene instantiation creates valid node" % scene_name
|
||||
)
|
||||
|
||||
@@ -144,7 +144,7 @@ func validate_scene_instantiation(scene_path: String):
|
||||
|
||||
|
||||
func test_critical_scenes():
|
||||
TestHelper.print_step("Critical Scene Validation")
|
||||
TestHelperClass.print_step("Critical Scene Validation")
|
||||
|
||||
# Define critical scenes that must work
|
||||
var critical_scenes = [
|
||||
@@ -157,13 +157,13 @@ func test_critical_scenes():
|
||||
for scene_path in critical_scenes:
|
||||
if scene_path in discovered_scenes:
|
||||
var status = validation_results.get(scene_path, "Unknown")
|
||||
TestHelper.assert_equal(
|
||||
TestHelperClass.assert_equal(
|
||||
"Full validation successful",
|
||||
status,
|
||||
"Critical scene %s must pass all validation" % scene_path.get_file()
|
||||
)
|
||||
else:
|
||||
TestHelper.assert_false(true, "Critical scene missing: %s" % scene_path)
|
||||
TestHelperClass.assert_false(true, "Critical scene missing: %s" % scene_path)
|
||||
|
||||
|
||||
func print_validation_summary():
|
||||
|
||||
Reference in New Issue
Block a user