feat(tests): harmonize and clean-up yarn test commands convention (#3695)

## What Harmonize and clean-up yarn test commands convention. ## Why Current strategy to filter integration tests from unit tests was cumbersome to maintain. Also, some packages declared `test:unit` which ended up being an alias to `test`. ## How * Remove all occurrences of `test:unit` * Rename all `test` commands under `/integration-tests/**/package.json` to `test:integration` * In the root `package.json`, rewrite `test:integration` command to run `turbo run test:integration` * In the root `package.json`, remove filtering on the `test` command * Introduce a new `test:integration` task in the Turborepo config.
2023-04-04 09:47:54 -04:00
parent 4bb1f833b1
commit 089f1eb19e
18 changed files with 31 additions and 31 deletions
--- a/.changeset/fuzzy-cheetahs-approve.md
+++ b/.changeset/fuzzy-cheetahs-approve.md
@@ -0,0 +1,5 @@
+---
+"@medusajs/medusa": patch
+---
+
+feat(tests): harmonize and clean-up yarn test commands convention
--- a/integration-tests/api/package.json
+++ b/integration-tests/api/package.json
@@ -5,7 +5,7 @@
  "license": "MIT",
  "private": true,
  "scripts": {
-    "test": "jest --silent=false --runInBand --bail --detectOpenHandles --forceExit",
+    "test:integration": "jest --silent=false --runInBand --bail --detectOpenHandles --forceExit",
    "build": "babel src -d dist --extensions \".ts,.js\""
  },
  "dependencies": {
--- a/integration-tests/package.json
+++ b/integration-tests/package.json
@@ -5,7 +5,7 @@
  "main": "jest.config.js",
  "private": true,
  "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test:integration": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "Zakaria S. El Asri",
  "license": "ISC",
--- a/integration-tests/plugins/package.json
+++ b/integration-tests/plugins/package.json
@@ -5,7 +5,7 @@
  "license": "MIT",
  "private": true,
  "scripts": {
-    "test": "jest --silent=false --runInBand --bail --detectOpenHandles --forceExit",
+    "test:integration": "jest --silent=false --runInBand --bail --detectOpenHandles --forceExit",
    "build": "babel src -d dist --extensions \".ts,.js\""
  },
  "dependencies": {
--- a/integration-tests/repositories/package.json
+++ b/integration-tests/repositories/package.json
@@ -5,7 +5,7 @@
  "license": "MIT",
  "private": true,
  "scripts": {
-    "test": "jest --silent=false --runInBand --bail --detectOpenHandles --forceExit"
+    "test:integration": "jest --silent=false --runInBand --bail --detectOpenHandles --forceExit"
  },
  "dependencies": {
    "@medusajs/medusa": "1.8.0-rc.6",
--- a/package.json
+++ b/package.json
@@ -70,11 +70,11 @@
    "lint:docs": "eslint -c docs/.eslintrc.js --ignore-path docs/.eslintignore docs/content",
    "prettier": "prettier",
    "jest": "jest",
-    "test": "turbo run test --no-daemon --filter=!integration-tests-api --filter=!integration-tests-plugins --filter=!integration-tests-repositories",
-    "test:integration": "turbo run test --no-daemon --filter=integration-tests-api --filter=integration-tests-plugins --filter=integration-tests-repositories",
-    "test:integration:api": "turbo run test --no-daemon --filter=integration-tests-api",
-    "test:integration:plugins": "turbo run test --no-daemon --filter=integration-tests-plugins",
-    "test:integration:repositories": "turbo run test --no-daemon --filter=integration-tests-repositories",
+    "test": "turbo run test --no-daemon",
+    "test:integration": "turbo run test:integration --no-daemon",
+    "test:integration:api": "turbo run test:integration --no-daemon --filter=integration-tests-api",
+    "test:integration:plugins": "turbo run test:integration --no-daemon --filter=integration-tests-plugins",
+    "test:integration:repositories": "turbo run test:integration --no-daemon --filter=integration-tests-repositories",
    "openapi:generate": "yarn ./packages/oas/oas-github-ci run ci",
    "medusa-oas": "yarn ./packages/oas/medusa-oas-cli run medusa-oas",
    "generate:services": "typedoc --options typedoc.services.js",
--- a/packages/cache-inmemory/package.json
+++ b/packages/cache-inmemory/package.json
@@ -27,8 +27,7 @@
    "watch": "tsc --build --watch",
    "prepare": "cross-env NODE_ENV=production yarn run build",
    "build": "tsc --build",
-    "test": "jest --passWithNoTests",
-    "test:unit": "jest --passWithNoTests"
+    "test": "jest --passWithNoTests"
  },
  "dependencies": {
    "@medusajs/modules-sdk": "0.1.0-rc.4"
--- a/packages/cache-redis/package.json
+++ b/packages/cache-redis/package.json
@@ -27,8 +27,7 @@
    "watch": "tsc --build --watch",
    "prepare": "cross-env NODE_ENV=production yarn run build",
    "build": "tsc --build",
-    "test": "jest --passWithNoTests",
-    "test:unit": "jest --passWithNoTests"
+    "test": "jest --passWithNoTests"
  },
  "dependencies": {
    "@medusajs/modules-sdk": "0.1.0-rc.4",
--- a/packages/event-bus-local/package.json
+++ b/packages/event-bus-local/package.json
@@ -27,8 +27,7 @@
    "watch": "tsc --build --watch",
    "prepare": "cross-env NODE_ENV=production yarn run build",
    "build": "tsc --build",
-    "test": "jest --passWithNoTests",
-    "test:unit": "jest --passWithNoTests"
+    "test": "jest --passWithNoTests"
  },
  "dependencies": {
    "@medusajs/modules-sdk": "0.1.0-rc.4",
--- a/packages/event-bus-redis/package.json
+++ b/packages/event-bus-redis/package.json
@@ -28,8 +28,7 @@
    "watch": "tsc --build --watch",
    "prepare": "cross-env NODE_ENV=production yarn run build",
    "build": "tsc --build",
-    "test": "jest --passWithNoTests",
-    "test:unit": "jest --passWithNoTests"
+    "test": "jest --passWithNoTests"
  },
  "dependencies": {
    "@medusajs/modules-sdk": "0.1.0-rc.4",
--- a/packages/inventory/package.json
+++ b/packages/inventory/package.json
@@ -33,7 +33,6 @@
    "watch": "tsc --build --watch",
    "prepare": "cross-env NODE_ENV=production yarn run build",
    "build": "tsc --build",
-    "test": "jest --passWithNoTests",
-    "test:unit": "jest --passWithNoTests"
+    "test": "jest --passWithNoTests"
  }
 }
--- a/packages/medusa/package.json
+++ b/packages/medusa/package.json
@@ -35,8 +35,7 @@
    "prepare": "cross-env NODE_ENV=production yarn run build",
    "build": "tsc --build",
    "serve": "node dist/app.js",
-    "test": "jest",
-    "test:unit": "jest"
+    "test": "jest"
  },
  "peerDependencies": {
    "@medusajs/types": "0.0.2-rc.1",
--- a/packages/modules-sdk/package.json
+++ b/packages/modules-sdk/package.json
@@ -33,7 +33,6 @@
  "scripts": {
    "prepare": "cross-env NODE_ENV=production yarn run build",
    "build": "tsc --build",
-    "test": "jest",
-    "test:unit": "jest"
+    "test": "jest"
  }
 }
--- a/packages/oas/medusa-oas-cli/package.json
+++ b/packages/oas/medusa-oas-cli/package.json
@@ -32,8 +32,7 @@
    "prepare": "cross-env NODE_ENV=production yarn run build",
    "build": "tsc --build",
    "medusa-oas": "ts-node src/index.ts",
-    "test": "jest src",
-    "test:unit": "jest src"
+    "test": "jest src"
  },
  "dependencies": {
    "@medusajs/medusa": "1.8.0-rc.6",
--- a/packages/oas/oas-github-ci/package.json
+++ b/packages/oas/oas-github-ci/package.json
@@ -18,8 +18,7 @@
    "ci": "node scripts/build-openapi.js",
    "preview:admin": "yarn redocly preview-docs ../../../docs/api/admin/openapi.yaml --config=../../../docs-util/redocly/config.yaml",
    "preview:store": "yarn redocly preview-docs ../../../docs/api/store/openapi.yaml --config=../../../docs-util/redocly/config.yaml",
-    "test": "jest --passWithNoTests",
-    "test:unit": "jest --passWithNoTests"
+    "test": "jest --passWithNoTests"
  },
  "dependencies": {
    "@medusajs/medusa-oas-cli": "0.2.0-rc.6",
--- a/packages/oas/openapi-typescript-codegen/package.json
+++ b/packages/oas/openapi-typescript-codegen/package.json
@@ -22,8 +22,7 @@
    "prepare": "cross-env NODE_ENV=production yarn run release",
    "build": "rollup --config --environment NODE_ENV:development",
    "release": "rollup --config --environment NODE_ENV:production",
-    "test": "jest --passWithNoTests",
-    "test:unit": "jest --passWithNoTests"
+    "test": "jest --passWithNoTests"
  },
  "dependencies": {
    "camelcase": "^6.3.0",
--- a/packages/stock-location/package.json
+++ b/packages/stock-location/package.json
@@ -33,7 +33,6 @@
    "watch": "tsc --build --watch",
    "prepare": "cross-env NODE_ENV=production yarn run build",
    "build": "tsc --build",
-    "test": "jest --passWithNoTests",
-    "test:unit": "jest --passWithNoTests"
+    "test": "jest --passWithNoTests"
  }
 }
--- a/turbo.json
+++ b/turbo.json
@@ -16,6 +16,12 @@
        "build"
      ],
      "outputs": []
+    },
+    "test:integration": {
+      "dependsOn": [
+        "build"
+      ],
+      "outputs": []
    }
  },
  "globalDependencies": [