feat(medusa): CSV formatter accounts for comma and semicolon (#2789)

Co-authored-by: Sebastian Rindom <skrindom@gmail.com>

packages/medusa/src/strategies/batch-jobs/product/utils.ts

@@ -17,11 +17,10 @@ export function pickObjectPropsByRegex(
 
   for (const k in data) {
     if (variantKeyPredicate(k)) {
-      const formattedData =
+      ret[k] =
         typeof data[k] === "string"
           ? csvRevertCellContentFormatter(data[k] as string)
           : data[k]
-      ret[k] = formattedData
     }
   }
 

packages/medusa/src/utils/__tests__/csv-cell-content-formatter.spec.ts

@@ -7,11 +7,27 @@ type Case = {
 
 const cases: [string, Case][] = [
   [
-    "should return the exact input when there is no new line char",
+    "should return a the exact input content",
+    {
+      str: "Hello my name is Adrien and I like writing single line content.",
+      expected:
+        'Hello my name is Adrien and I like writing single line content.',
+    },
+  ],
+  [
+    "should return a formatted string escaping the coma",
     {
       str: "Hello, my name is Adrien and I like writing single line content.",
       expected:
-        "Hello, my name is Adrien and I like writing single line content.",
+        '"Hello, my name is Adrien and I like writing single line content."',
+    },
+  ],
+  [
+    "should return a formatted string escaping the semicolon",
+    {
+      str: "Hello; my name is Adrien and I like writing single line content.",
+      expected:
+        '"Hello; my name is Adrien and I like writing single line content."',
     },
   ],
   [

packages/medusa/src/utils/csv-cell-content-formatter.ts

@@ -1,9 +1,13 @@
 export function csvCellContentFormatter(str: string): string {
   const newLineRegexp = new RegExp(/\n/g)
   const doubleQuoteRegexp = new RegExp(/"/g)
+  const comaRegexp = new RegExp(/,/g)
+  const semicolonRegexp = new RegExp(/;/g)
 
   const hasNewLineChar = !!str.match(newLineRegexp)
-  if (!hasNewLineChar) {
+  const hasComaChar = !!str.match(comaRegexp)
+  const hasSemicolonChar = !!str.match(semicolonRegexp)
+  if (!hasNewLineChar && !hasComaChar && !hasSemicolonChar) {
     return str
   }