asyavee/medusa-store
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(medusa): Select config should be undefined if length === 0 (#2469)

Browse Source
This commit is contained in:
Adrien de Peretti
2022-10-20 13:25:23 +02:00
committed by GitHub
parent 2f00bd100a
commit 13611e3e53
3 changed files with 15 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/eleven-cooks-jump.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@medusajs/medusa": patch
---
fix(medusa): Select config should be undefined if length === 0

6
packages/medusa/src/services/cart.ts
View File

@@ -334,11 +334,7 @@ class CartService extends TransactionBaseService {
query.relations = relations
}
if (select && select.length > 0) {
query.select = select
} else {
query.select = undefined
}
query.select = select?.length ? select : undefined
const queryRelations = query.relations
query.relations = undefined

43
packages/medusa/src/services/order.ts
View File

@@ -166,25 +166,8 @@ class OrderService extends TransactionBaseService {
order: { created_at: "DESC" },
}
): Promise<Order[]> {
const orderRepo = this.manager_.getCustomRepository(this.orderRepository_)
const query = buildQuery(selector, config)
const { select, relations, totalsToSelect } =
this.transformQueryForTotals(config)
if (select && select.length) {
query.select = select
}
if (relations && relations.length) {
query.relations = relations
}
const raw = await orderRepo.find(query)
return await Promise.all(
raw.map(async (r) => await this.decorateTotals(r, totalsToSelect))
)
const [orders] = await this.listAndCount(selector, config)
return orders
}
/**
@@ -241,11 +224,9 @@ class OrderService extends TransactionBaseService {
const { select, relations, totalsToSelect } =
this.transformQueryForTotals(config)
if (select && select.length) {
query.select = select
}
query.select = select
const rels = relations
delete query.relations
const raw = await orderRepo.findWithRelations(rels, query)
@@ -314,14 +295,14 @@ class OrderService extends TransactionBaseService {
select = select.filter((v) => !totalFields.includes(v))
}
const toSelect = [...select]
const toSelect = select
if (toSelect.length > 0 && toSelect.indexOf("tax_rate") === -1) {
toSelect.push("tax_rate")
}
return {
relations,
select: toSelect,
select: toSelect.length ? toSelect : undefined,
totalsToSelect,
}
}
@@ -349,9 +330,7 @@ class OrderService extends TransactionBaseService {
query.relations = relations
}
if (select && select.length > 0) {
query.select = select
}
query.select = select?.length ? select : undefined
const rels = query.relations
delete query.relations
@@ -389,9 +368,7 @@ class OrderService extends TransactionBaseService {
query.relations = relations
}
if (select && select.length > 0) {
query.select = select
}
query.select = select?.length ? select : undefined
const raw = await orderRepo.findOne(query)
@@ -428,9 +405,7 @@ class OrderService extends TransactionBaseService {
query.relations = relations
}
if (select && select.length > 0) {
query.select = select
}
query.select = select?.length ? select : undefined
const rels = query.relations
delete query.relations