fix: workflow 'when' should return T or undefined instead of Partial<T> (#8195)

* fix: workflow 'when' should return T or undefined instead of Partial<T>

* fix when usage
This commit is contained in:
Adrien de Peretti
2024-07-19 10:46:55 +02:00
committed by GitHub
parent 78b8a3c60f
commit 35c3759ed8
3 changed files with 7 additions and 7 deletions

View File

@@ -7,11 +7,11 @@ import {
} from "@medusajs/types"
import { ChangeActionType, OrderChangeStatus } from "@medusajs/utils"
import {
WorkflowData,
createStep,
createWorkflow,
transform,
when,
WorkflowData,
} from "@medusajs/workflows-sdk"
import { useRemoteQueryStep } from "../../../common"
import { createOrderChangeActionsStep } from "../../steps/create-order-change-actions"
@@ -88,7 +88,7 @@ export const orderClaimRequestItemReturnWorkflow = createWorkflow(
const orderReturn: ReturnDTO = transform(
{ createdReturn, existingOrderReturn, orderClaim },
({ createdReturn, existingOrderReturn, orderClaim }) => {
return existingOrderReturn ?? (createdReturn[0] as ReturnDTO)
return existingOrderReturn ?? (createdReturn?.[0] as ReturnDTO)
}
)
@@ -130,7 +130,7 @@ export const orderClaimRequestItemReturnWorkflow = createWorkflow(
const createdReturnId = transform(
{ createdReturn },
({ createdReturn }) => {
return createdReturn[0]!.id
return createdReturn?.[0]!.id
}
)
updateOrderClaimsStep([

View File

@@ -7,11 +7,11 @@ import {
} from "@medusajs/types"
import { ChangeActionType, OrderChangeStatus } from "@medusajs/utils"
import {
WorkflowData,
createStep,
createWorkflow,
transform,
when,
WorkflowData,
} from "@medusajs/workflows-sdk"
import { useRemoteQueryStep } from "../../../common"
import { createOrderChangeActionsStep } from "../../steps/create-order-change-actions"
@@ -89,7 +89,7 @@ export const orderExchangeRequestItemReturnWorkflow = createWorkflow(
const orderReturn: ReturnDTO = transform(
{ createdReturn, existingOrderReturn, orderExchange },
({ createdReturn, existingOrderReturn, orderExchange }) => {
return existingOrderReturn ?? (createdReturn[0] as ReturnDTO)
return existingOrderReturn ?? (createdReturn?.[0] as ReturnDTO)
}
)
@@ -128,7 +128,7 @@ export const orderExchangeRequestItemReturnWorkflow = createWorkflow(
const createdReturnId = transform(
{ createdReturn },
({ createdReturn }) => {
return createdReturn[0]!.id
return createdReturn?.[0]!.id
}
)
updateOrderExchangesStep([

View File

@@ -13,7 +13,7 @@ type ConditionFunction<T extends object | WorkflowData> = (
type ThenFunc = <ThenResolver extends () => any>(
resolver: ThenResolver
) => ReturnType<ThenResolver> extends WorkflowData<infer ReturnedWorkflowData>
? Partial<WorkflowData<ReturnedWorkflowData>>
? WorkflowData<ReturnedWorkflowData> | undefined
: ReturnType<ThenResolver>
export function when<T extends object | WorkflowData, Then extends Function>(