fix(medusa): cart completion payment sessions (#5995)

* fix(medusa): cart completion payment sessions

* Create seven-moose-scream.md

* fix unit tests

.changeset/seven-moose-scream.md

@@ -0,0 +1,5 @@
+---
+"@medusajs/medusa": patch
+---
+
+fix(medusa): cart completion payment sessions

packages/medusa/src/strategies/__tests__/cart-completion.js

@@ -62,9 +62,7 @@ const toTest = [
 
         expect(cartServiceMock.authorizePayment).toHaveBeenCalledTimes(1)
         expect(cartServiceMock.authorizePayment).toHaveBeenCalledWith(
-          expect.objectContaining({
-            id: "test-cart",
-          }),
+          "test-cart",
           {
             idempotency_key: {
               idempotency_key: "ikey",

packages/medusa/src/strategies/cart-completion.ts

@@ -2,13 +2,12 @@ import {
   IEventBusService,
   IInventoryService,
   ReservationItemDTO,
-  WithRequiredProperty,
 } from "@medusajs/types"
 import {
   AbstractCartCompletionStrategy,
   CartCompletionResponse,
 } from "../interfaces"
-import { Cart, IdempotencyKey, Order } from "../models"
+import { IdempotencyKey, Order } from "../models"
 import {
   PaymentProviderService,
   ProductVariantInventoryService,
@@ -247,39 +246,10 @@ class CartCompletionStrategy extends AbstractCartCompletionStrategy {
 
     const txCartService = this.cartService_.withTransaction(manager)
 
-    let cart: Cart | WithRequiredProperty<Cart, "total"> =
-      await txCartService.retrieveWithTotals(id, {
-        relations: [
-          "items.variant.product.profiles",
-          "items.adjustments",
-          "discounts",
-          "discounts.rule",
-          "gift_cards",
-          "shipping_methods",
-          "shipping_methods.shipping_option",
-          "billing_address",
-          "shipping_address",
-          "region",
-          "region.tax_rates",
-          "region.payment_providers",
-          "payment_sessions",
-          "customer",
-        ],
-      })
-
-    if (cart.payment_sessions?.length) {
-      await txCartService.setPaymentSessions(
-        cart as WithRequiredProperty<Cart, "total">
-      )
-    }
-
-    cart = await txCartService.authorizePayment(
-      cart as WithRequiredProperty<Cart, "total">,
-      {
-        ...context,
-        idempotency_key: idempotencyKey,
-      }
-    )
+    const cart = await txCartService.authorizePayment(id, {
+      ...context,
+      idempotency_key: idempotencyKey,
+    })
 
     if (cart.payment_session) {
       if (