fix: Listening events (#7474)

* fix: Listening events

* cleanup
This commit is contained in:
Adrien de Peretti
2024-05-27 15:31:57 +02:00
committed by GitHub
parent 10ef32c5a3
commit 45bcdfec17
4 changed files with 25 additions and 26 deletions

View File

@@ -63,15 +63,17 @@ module.exports = {
}
return await new Promise((resolve, reject) => {
expressServer = app.listen(port, async (err) => {
if (err) {
expressServer = app
.listen(port)
.on("error", async (err) => {
await shutdown()
return reject(err)
}
setPort(port)
process.send(port)
resolve(shutdown)
})
})
.on("listening", () => {
setPort(port)
process.send(port)
resolve(shutdown)
})
setExpressServer(expressServer)
})

View File

@@ -60,18 +60,21 @@ export async function startApp({
}
return await new Promise((resolve, reject) => {
const server = app.listen(port).on("error", async (err) => {
await shutdown()
return reject(err)
})
const server = app
.listen(port)
.on("error", async (err) => {
await shutdown()
return reject(err)
})
.on("listening", () => {
process.send?.(port)
process.send?.(port)
resolve({
shutdown,
container,
port,
})
resolve({
shutdown,
container,
port,
})
})
// TODO: fix that once we find the appropriate place to put this util
const {

View File

@@ -61,10 +61,7 @@ export default async function ({ port, cpus, directory }) {
})
const serverActivity = Logger.activity(`Creating server`)
const server = GracefulShutdownServer.create(
app.listen(port).on("error", (err) => {
if (err) {
return
}
app.listen(port).on("listening", () => {
Logger.success(serverActivity, `Server is ready on port: ${port}`)
track("CLI_START_COMPLETED")
})

View File

@@ -26,10 +26,7 @@ export default async function ({ port, directory }) {
const serverActivity = Logger.activity(`Creating server`)
const server = GracefulShutdownServer.create(
app.listen(port).on("error", (err) => {
if (err) {
return
}
app.listen(port).on("listening", () => {
Logger.success(serverActivity, `Server is ready on port: ${port}`)
track("CLI_START_COMPLETED")
})