fix: Listening events (#7474)

* fix: Listening events

* cleanup

integration-tests/environment-helpers/bootstrap-app.js

@@ -63,11 +63,13 @@ module.exports = {
     }
 
     return await new Promise((resolve, reject) => {
-      expressServer = app.listen(port, async (err) => {
+      expressServer = app
-        if (err) {
+        .listen(port)
+        .on("error", async (err) => {
           await shutdown()
           return reject(err)
-        }
+        })
+        .on("listening", () => {
           setPort(port)
           process.send(port)
           resolve(shutdown)

packages/core/medusa-test-utils/src/medusa-test-runner-utils/bootstrap-app.ts

@@ -60,11 +60,13 @@ export async function startApp({
   }
 
   return await new Promise((resolve, reject) => {
-    const server = app.listen(port).on("error", async (err) => {
+    const server = app
+      .listen(port)
+      .on("error", async (err) => {
         await shutdown()
         return reject(err)
       })
-
+      .on("listening", () => {
         process.send?.(port)
 
         resolve({
@@ -72,6 +74,7 @@ export async function startApp({
           container,
           port,
         })
+      })
 
     // TODO: fix that once we find the appropriate place to put this util
     const {

packages/medusa/src/commands/start-cluster.ts

@@ -61,10 +61,7 @@ export default async function ({ port, cpus, directory }) {
       })
       const serverActivity = Logger.activity(`Creating server`)
       const server = GracefulShutdownServer.create(
-        app.listen(port).on("error", (err) => {
+        app.listen(port).on("listening", () => {
-          if (err) {
-            return
-          }
           Logger.success(serverActivity, `Server is ready on port: ${port}`)
           track("CLI_START_COMPLETED")
         })

packages/medusa/src/commands/start.ts

@@ -26,10 +26,7 @@ export default async function ({ port, directory }) {
 
       const serverActivity = Logger.activity(`Creating server`)
       const server = GracefulShutdownServer.create(
-        app.listen(port).on("error", (err) => {
+        app.listen(port).on("listening", () => {
-          if (err) {
-            return
-          }
           Logger.success(serverActivity, `Server is ready on port: ${port}`)
           track("CLI_START_COMPLETED")
         })