fix(medusa): Race condition in cart completion strategy (#2341)

2022-10-04 16:31:36 +02:00
parent 94eb2bfc02
commit 5908d9b9b6
1 changed files with 9 additions and 3 deletions
--- a/packages/medusa/src/strategies/cart-completion.ts
+++ b/packages/medusa/src/strategies/cart-completion.ts
@@ -328,9 +328,15 @@ class CartCompletionStrategy extends AbstractCartCompletionStrategy {
    if (err) {
      if (idempotencyKey.recovery_point !== "started") {
        await this.manager_.transaction(async (transactionManager) => {
-          await cartService
-            .withTransaction(transactionManager)
-            .deleteTaxLines(id)
+          try {
+            await orderService
+              .withTransaction(transactionManager)
+              .retrieveByCartId(id)
+          } catch (error) {
+            await cartService
+              .withTransaction(transactionManager)
+              .deleteTaxLines(id)
+          }
        })
      }
      throw err