Fix not in promotion rule empty value validation (#14172)

.changeset/thick-shrimps-peel.md

@@ -0,0 +1,5 @@
+---
+"@medusajs/promotion": patch
+---
+
+Fix not in promotion rule empty value validation

packages/modules/promotion/integration-tests/__tests__/services/promotion-module/evaluate-rule-value-condition.spec.ts

@@ -35,6 +35,7 @@ moduleIntegrationTestRunner({
           expect(testFunc(["2"], operator, [2])).toEqual(false)
           expect(testFunc(["2"], operator, ["2"])).toEqual(false)
           expect(testFunc(["2"], operator, ["22"])).toEqual(true)
+          expect(testFunc(["2"], operator, [])).toEqual(true)
         })
       })
 

packages/modules/promotion/src/utils/validations/promotion-rule.ts

@@ -118,7 +118,12 @@ export function evaluateRuleValueCondition(
     : [ruleValuesToCheck]
 
   if (!valuesToCheck.length) {
-    return false
+    switch (operator) {
+      case "ne":
+        return true
+      default:
+        return false
+    }
   }
 
   switch (operator) {