Fix not in promotion rule empty value validation (#14172)

2025-12-01 15:04:57 +01:00
parent ee1be833c3
commit 6bc5bf4fc9
3 changed files with 12 additions and 1 deletions
--- a/packages/modules/promotion/integration-tests/tests/services/promotion-module/evaluate-rule-value-condition.spec.ts
+++ b/packages/modules/promotion/integration-tests/tests/services/promotion-module/evaluate-rule-value-condition.spec.ts
@@ -35,6 +35,7 @@ moduleIntegrationTestRunner({
          expect(testFunc(["2"], operator, [2])).toEqual(false)
          expect(testFunc(["2"], operator, ["2"])).toEqual(false)
          expect(testFunc(["2"], operator, ["22"])).toEqual(true)
+          expect(testFunc(["2"], operator, [])).toEqual(true)
        })
      })

--- a/packages/modules/promotion/src/utils/validations/promotion-rule.ts
+++ b/packages/modules/promotion/src/utils/validations/promotion-rule.ts
@@ -118,7 +118,12 @@ export function evaluateRuleValueCondition(
    : [ruleValuesToCheck]

  if (!valuesToCheck.length) {
-    return false
+    switch (operator) {
+      case "ne":
+        return true
+      default:
+        return false
+    }
  }

  switch (operator) {